Problem/Motivation

Thanks for this wonderful module!

It's working great in Firefox and Chrome but not in Brave browser. The consent popup is not visible but the page is blocked.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 3389613.patch2.59 KBkallado

Comments

AlfTheCat created an issue. See original summary.

kallado’s picture

kallado commented

@AlfTheCat This should be solved in version 1.0.4
https://www.drupal.org/project/consent_popup/issues/3385450

Can you please review so I can mark this as a duplicate.

kallado’s picture

kallado commented
Assigned: Unassigned » kallado
Status: Active » Needs review
alfthecat’s picture

alfthecat commented
Assigned: kallado » Unassigned
Status: Needs review » Closed (duplicate)
Related issues: +#3385450: Doesn't work for anonymous users

Awesome! Thanks.

alfthecat’s picture

alfthecat commented

Sorry we updated at the same time 😁

alfthecat’s picture

alfthecat commented
Status: Closed (duplicate) » Needs work

@kallado on review I already had 1.0.4 installed. Just to be sure I updated to the latest dev. The bug in Brave is still there.

kallado’s picture

kallado commented
StatusFileSize
new 3389613.patch2.59 KB

Patch created check if it works and let me know.

daniela.costa’s picture

daniela.costa commented

Patch #7 is working correctly for me.

  • kallado committed f628473e on 1.0.x 
    Issue #3389613 by kallado, AlfTheCat, daniela.costa: Not working on in...
kallado’s picture

kallado commented

Ok patch cmmited to dev.
@AlfTheCat I'm not sure when a new release will be availabe because to be honest this isn't a bug from module.
The module is suposed to show a consent popup, it does.
You choose to use a browser that blocks consent popups, it does.
Everything works as expected.
Anyway the patch works.

alfthecat’s picture

alfthecat commented
Status: Needs work » Needs review

Patch solves the issue for me, however, it did break some of my custom CSS due to the CSS ID change.

kallado’s picture

kallado commented
Status: Needs review » Closed (works as designed)
kallado’s picture

kallado commented