Closed (fixed)
Project:
Drupal core
Version:
10.3.x-dev
Component:
file.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Sep 2023 at 04:01 UTC
Updated:
10 Jun 2024 at 21:51 UTC
Jump to comment: Most recent
Comments
Comment #3
kim.pepperChanged title from 'move' to 'add' since we aren't moving in this issue.
Comment #4
smustgrave commentedChange looks good and is all green. The CR could use some updates though.
Thanks!
Comment #5
kim.pepperUpdated change record
Comment #6
smustgrave commentedThanks!
Comment #8
quietone commentedI'm triaging RTBC issues. I read the IS and the comments. I didn't find any unanswered questions.
But this needs to be rebased.
Comment #9
kim.pepperRe-rolled. Back to RTBC
Comment #10
kim.pepperI think we should postpone this on #3388985: Make CKEditor5ImageController reuse FileUploadHandler so we have an example of moving the locking rather just adding it as we do here.
Comment #11
larowlanBlocker is in
Comment #12
kim.pepperRebased on 11.x
Comment #13
smustgrave commentedSeems to have failing tests, reran but still failed.
Comment #14
kim.pepperNeeded to set
$throwstoFALSEafter the change in #3375447: Create an UploadedFile validator and deprecate error checking methods on UploadedFileInterfaceComment #15
smustgrave commentedThat seemed to be it!
Comment #16
larowlanLeft some comments on the MR
Comment #17
kim.pepperComment #18
smustgrave commentedFeedback appears to be addressed.
Comment #19
bklineI don't think this deprecation message means what it says, which is that calls to the
FileUploadHandlerconstructor will be required to omit the$lockargument in drupal:11.0.0. There are a number of spots like this in the patch.Perhaps you meant "prohibited" or "prevented" where you have "required"?
Comment #20
kim.pepper#19 No it's correct as it is. We are adding a new
$lockdependency, which will throw a deprecation warning if it's not provided in 10.3.0, and as a BC layer, we look up the service using\Drupal::service(). But in Drupal 11.0.0 we remove this BC layer and it will throw an error if it's not provided.Comment #21
bkline@kim.pepper Your description in #20 matches what I assumed you meant the deprecation message to convey, but that's not what it actually says. If you read its language carefully, you'll realize that "Calling" is the subject of both verbs, so parsed correctly, the meaning is as follows:
"Calling __construct() without the $lock argument is deprecated in drupal:10.3.0."
and
"Calling __construct() without the $lock argument is required in drupal:11.0.0."
Comment #22
kim.pepper'Calling ' . __METHOD__ . '() without the $lock argument is deprecated in drupal:10.3.0 and is required in drupal:11.0.0' is correct.
Comment #23
bklineSigh. Oh, well, at least they're just deprecation messages, so they be gone eventually, along with the incorrect wording. 🙄
Comment #24
kim.pepperFeel free to open a [Policy, No Patch] issue to suggest changes to the wording. We have a phpcs rule to ensure it matches the official pattern. See https://www.drupal.org/about/core/policies/core-change-policies/drupal-d...
Comment #25
alexpottThis is a nice improvement to the API.
Committed and pushed 6236d36180 to 11.x and e44ea05058 to 10.3.x. Thanks!