Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Sep 2023 at 22:25 UTC
Updated:
19 Oct 2023 at 06:54 UTC
Jump to comment: Most recent, Most recent file
Show commands
changes
Comments
Comment #3
longwaveComment #4
longwaveNot sure what I am doing wrong here. I think I have followed the docs in https://docs.gitlab.com/ee/ci/pipelines/downstream_pipelines.html?tab=Pa... but the child pipeline immediately fails with "This job could not start because it could not retrieve the needed artifacts."
The parent pipeline seems OK and the other jobs there correctly download the artifacts.
Comment #5
longwaveSeems to be working! The error I made previously was that the default
variablesis overwritten by the job-specificvariables.This still needs work to tidy up the variables and also the use of the caches, some of which is redundant now.
Comment #6
catchI just opened #3391608: Move lint jobs to the pipeline (moving everything to the child pipeline) which would conflict with this. The goal is very similar so we should go ahead here and then the other issue will have a better baseline to deal with.
Comment #7
longwaveCleaned up the use of
cache- we only need this in the build steps, after this we are passing around artifacts instead and so the lint and test jobs don't need caches.Also moved
stagein the child pipeline to the defaults, given that we only have one stage now.Comment #8
longwaveAlso ensured that build (and lint) run on scheduled pipelines, because the test jobs now need the parent build job artifacts.
Comment #9
catchThis covers 90% of what I wanted to get from #3391608: Move lint jobs to the pipeline and the last 10% is quite marginal, so closed as duplicate.
MR looks great to me.
Comment #10
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #11
longwaveRebased.
Comment #12
catchThis is excellent and low risk. Will commit in ~24 hours if no objections, or sooner if there's a +1.
Comment #13
fjgarlin commented+1 from my side for what is worth.
I love the ability of referencing parent pipelines jobs in the “needs” section. I think it’sa great refactoring.
Comment #16
lauriiiNice work @longwave! 👏
Committed 4a70e44 and pushed to 11.x. Thanks!