Closed (fixed)
Project:
Navigation
Version:
1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
19 Sep 2023 at 18:26 UTC
Updated:
8 Nov 2023 at 12:54 UTC
Jump to comment: Most recent
Comments
Comment #3
saschaeggiComment #4
saschaeggiComment #5
saschaeggiComment #6
lauriiiMerged the MR! It's good enough for now. We'll have to still update the code to get rid of the hard coded entity types so that it doesn't break if you don't have some of the modules enabled.
Comment #9
lauriiiGot feedback from @ckrina that we should not introduce the submenus to the "Create" menu, and that we should implement a solution that displays a filtered list of options but on a single level.
Comment #10
saschaeggiI like the flat hierarchy but the potential problem I see with this approach is that you can end up with items with the same name from different entitites. So we would need to either
a) Categorize them (using type titles)
b) Show which entity type it is on each item
Let's discuss this at DrupalCon ☺️
Comment #11
ckrinaAgreed, we need to have the conversation about having an special UI to handle this. I'd be great to get a first draft of the "what" defined at DrupalCon.
Anyway, for solving this specific issue for now I'd go with 2 tickets so we can ask to people what they see more useful:
Option 1, merged to keep a closer result of what we have right now:
Option 2, open a MR with the existing proposal in this MR. But maybe without blocks?
Thoughts?
Comment #12
saschaeggiI think both work well, as long as we somehow can overcome the hardcoded links as a first iteration.
Let's discuss this later this week so we can get a first iteration in and working on the end result how the "pie in the sky" version should look like
Comment #13
saschaeggi@ckrina and I discussed how we want to move forward with this for now:
We'll keep the content types while removing Blocks, Media & Taxonomy for now (as an intermediate solution).
The following links should be added (maybe manually):
Also have a look at https://www.drupal.org/project/gin/issues/3394085 for adding the code to check if types actually exist and the corresponding modules are enabled.
Comment #14
saschaeggiComment #15
saschaeggiComment #18
markie commentedReviewed the work done in Gin and used a bit of the code to verify content types, block types, term vocabularies, and if media is enabled, media items. Fun fact, Image and Files are media entities, so if the module isn't enabled, it won't have an add path. I wanted to capture the logic in this branch with a commit before removing blocks, media and taxonomy, but also would like y'all to look at the result and see if maybe it becomes acceptable.
Comment #19
markie commentedForgot our fancy tag..
Comment #20
ckrinaThanks @markie! What @saschaeggi meant in comment #13 is that we want to remove the submenu and groupings from the Create item, so we have a list without anything opening a submenu. So it would look like:
Comment #21
markie commentedUpdated listing and verified that if media exists, the proper items are shown. I feel that we should list all media entity types but that's up to y'all.
Comment #22
saschaeggiHey @markie thanks for working on this. I left some comments/suggestions in the MR 👀
Comment #24
kostyashupenkoComment #25
ckrinaThanks for moving this forward!
The content menu should end up being (at least for now):
The File in the Content creation item is missing, and also the link to Media. So moving this to NW.
This is also removing the Blocks. I don't think it's a big deal for now, but we'll need to validate that in follow-ups.
Comment #26
saschaeggiThis one might be my mistake as it seems i marked the wrong lines for removal, sorry!
Comment #27
markie commentedI would like to reiterate that there is no `/file/add` or anything so the closest thing we have is the "Document" media entity type. I realize the one I added was removed at Sascha's request. Would you like that named "File" instead of "Document"?
Comment #28
ckrinaAgh, that’s right that it’s called Document. So yeah, I’d use Document instead of File for now (and let’s figure out later the best default, but at least we can test now and get some feedback).
Thanks!
Comment #29
ckrinaMerging this so we can start working on top of it. Thanks all!