Closed (fixed)
Project:
Commerce Stripe
Version:
8.x-1.x-dev
Component:
Payment Element
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Sep 2023 at 07:54 UTC
Updated:
19 Oct 2023 at 19:09 UTC
Jump to comment: Most recent
Comments
Comment #4
vmarchukComment #6
vmarchukComment #7
rszrama commentedReviewing this, I have some follow-ups and some questions. First the things we need to change:
payment_intent.succeededwebhook before the site had completed the original checkout. We would not need a warning in the logs for a webhook we know we can ignore.I also had a follow-up questions based on my review of
StripePaymentElement:createPayment(): did we never arrive at a conclusion regarding the deletion of a payment method when a payment attempt failed? I still see$this->deletePaymentMethod($payment_method);in there, which surprised me, as this deletes the payment method locally and remotely, no questions asked. That still seems like overkill to me, especially if you consider that payment method may be tied to other pending payments or recurring payments in Stripe or Drupal ... do we have a separate ticket to address it perhaps?Comment #8
rszrama commentedInteresting note: even though a partial capture will appear in the Stripe UI as a partial refund, they don't actually send a refund webhook, just the
payment_intent.succeededwebhook, even though the payload will have the "refund" in its object.Comment #9
vmarchuk@rszrama
Yes, but in this case we are only interested in payment_intent.succeeded event.
Comment #10
rszrama commentedI think we can move forward without a full solution for the unnecessary logs in 4/5. I'll just remove logging from her for now on commit, and we can work that logging in via #3389207: Add an option to log incoming webhooks to watchdog.
Comment #13
rszrama commented