Problem/Motivation

There are multiple functions that accept a `$rendering_object` parameter.
Depending where you look, this is documented as
- "The entity / form being rendered."
- "The object / entity beïng rendered."

However, it seems this value is never an object, but an array.

Steps to reproduce

Proposed resolution

Clarify this in the documentation in the doc comments.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 after-MR39-configuration.png64.3 KBtirupati_singh
#11 after-MR39-fixes.png72.05 KBtirupati_singh
#9 MR-39_field-group.png73.61 KBtirupati_singh
#9 MR-38_field-group.png87.87 KBtirupati_singh

Issue fork field_group-3387046

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

donquixote created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs work

rajdip_755 made their first commit to this issue’s fork.

elber opened merge request !38

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: Unassigned » elber
elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Assigned: elber » Unassigned
Status: Needs work » Needs review

Hi please revise

rajdip_755 opened merge request !39

rajdip_755’s picture

rajdip_755
Primary language Bengali
Location kolkata
commented
tirupati_singh’s picture

tirupati_singh commented
Status: Needs review » Needs work
StatusFileSize
new MR-38_field-group.png87.87 KB
new MR-39_field-group.png73.61 KB

Hi, I've applied both the MR !39 and MR !38 as patches and got error while applying the patches. I think it has occurred due to the presence of merge conflicts on both the MRs. I've reviewed both the MRs and found that the MR !38 only changes the doc comments @param type for only 3 files and the MR !39 has updated both doc comments and parameter name as per the @param type for all the file wherever it has been used. I think MR! 39 has the appropriate changes for the raised issue and MR !38 has only few changes, so MR !38 can be closed for now.
I've tested the changes made on MR !39 by checking out the 3387046-revise-rendering-object branch and the module functionlality is working fine. Got no errors while using the module. I've attached the screenshots for reference.

As there's merge error/conflicts present for MR !39 and few changes still required, hence changing the issue status to Needs work.

@rajdip_755, I've left comments on MR !39 please have a look.

rajdip_755’s picture

rajdip_755
Primary language Bengali
Location kolkata
commented
Status: Needs work » Needs review

Thanks @Tirupati_Singh for reviewing the MR.

I've updated the MR as per the changes requested. Please review the updated MR.

tirupati_singh’s picture

tirupati_singh commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after-MR39-fixes.png72.05 KB
new after-MR39-configuration.png64.3 KB

I've tested the changes made on MR !39 and can confirm that the issue has been resolved successfully. I'm attaching the screenshots for reference. Hence moving the status to RTBC.

anybody changed the visibility of the branch 3387046-the-renderingobject-parameter to hidden.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-3.x-dev » 4.x-dev
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Category: Task » Bug report
Priority: Normal » Minor
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Needs work

Ppeline is failing!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Needs review
benstallings’s picture

benstallings commented
Status: Needs review » Needs work

The MR has a merge conflict with the 4.x branch.

benstallings’s picture

benstallings commented
Assigned: Unassigned » benstallings
benstallings’s picture

benstallings commented
Assigned: benstallings » Unassigned
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks @benstallings LGTM. I just left one comment, think we should remove the CHANGELOG entirely. Doesn't HAVE to be done here, but we should do it IMHO.

  • anybody committed ba059098 on 4.x authored by rajdip_755 
    Issue #3387046 by rajdip_755, Tirupati_Singh, elber : Resolve the...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.