Problem/Motivation

Missed some comments and formatting for the taxonomy_facets.module file.

Please, fix all of that with Code Sniffer.

CommentFileSizeAuthor
#3 taxonomy_facets-3385661-1.patch5.48 KBmohd sahzad
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

_shY created an issue. See original summary.

mohd sahzad’s picture

Assigned: Unassigned » mohd sahzad
mohd sahzad’s picture

StatusFileSize
new5.48 KB

I have fixed this issue Missed some comments and formatting for the taxonomy_facets.module file.

mohd sahzad’s picture

Assigned: mohd sahzad » Unassigned

Terry_Kolodiy made their first commit to this issue’s fork.

_shy’s picture

Thank you, Mohd Sahzad.

All coding standard issues were fixed, but still, some moments are missing.

Empty description blocks should be deleted also, and we still have a taxonomy_facets_node_presave() which is do nothing and should be deleted as well.

_shy’s picture

And it will be nice to create an MR instead of a patch.

terry_kolodiy’s picture

Assigned: Unassigned » terry_kolodiy

terry_kolodiy’s picture

Assigned: terry_kolodiy » Unassigned
_shy’s picture

Thanks guys for your time.

Merged to 8.x-2.x!

_shy’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.