Problem/Motivation

GoogleTagUpgradeManager::upgradeGoogleTagEntities() short-circuits early if there are no Google Tag container entities to manipulate, leaving the google_tag.settings in their original 1.x state.

We should always update the settings accordingly.

Steps to reproduce

Attempt an update from 1.x to 2.x without any google tag containers configured.

Proposed resolution

Improve fidelity of the upgrade path.

Remaining tasks

Provide issue fork/patch.

User interface changes

N/A

CommentFileSizeAuthor
#4 google_tag-3385616-improved-1.x-upgrade-path-4.diff12.54 KBcodebymikey

Issue fork google_tag-3385616

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

codebymikey created an issue. See original summary.

codebymikey’s picture

codebymikey commented
Related issues: +#3350675: Google Analytics 4.x migration, +#3382757: GoogleTagUpgradeManager not mapping negate values correctly

codebymikey opened merge request !55

codebymikey’s picture

codebymikey commented
Status: Active » Needs review
StatusFileSize
new google_tag-3385616-improved-1.x-upgrade-path-4.diff12.54 KB

japerry made their first commit to this issue’s fork.

japerry’s picture

japerry
Location KOMK
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.