Problem/Motivation

  • Fix CSS to not use ID selector.
  • Remove id selector in the following css files because it is not used:
    modules/cloud_service_providers/openstack/css/openstack_launch_template_radios.css

Issue fork cloud-3385269

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sekinet created an issue. See original summary.

sekinet opened merge request !1975

shubham_jain’s picture

shubham_jain commented

Hi, can you please explain what have you done as I am a rookie.

sekinet’s picture

sekinet commented
Issue summary: View changes
sekinet’s picture

sekinet commented
Status: Active » Needs review

@yas

Could you please review the patch?

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3385266: Add CSS support for radio select and checkbox form fields
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for the fix. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 20206e33 on 6.x authored by sekinet 
    Issue #3385269 by sekinet, yas, shubham_jain: Fix CSS to not use ID...
sekinet’s picture

sekinet commented

@shubham_jain

The CSS file in Problem/Motivation was using an ID selector, which was causing an error in the Lint style check. This Issue is to remove that css file. The layout is broken as it is, so we are taking action to add CSS in the Rigel theme in Related issues.

  • yas committed 6543ec9e on 5.x authored by sekinet 
    Issue #3385269 by sekinet, yas: Fix CSS to not use ID selector
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
shubham_jain’s picture

shubham_jain commented

Hi @sekinet, thanks for explaining.

shubham_jain’s picture

shubham_jain commented
Status: Fixed » Closed (fixed)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Closed (fixed) » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@shubham_jain

Keep the issue queue by Fixed status for two weeks.

See also:

shubham_jain’s picture

shubham_jain commented

@yas, thanks for explaing that I thought that you have to close the issue as soon as it is fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.