Problem/Motivation

Right now, we have explicit logic in StageBase to exclude the failure marker file from stage operations (in particular, the apply phase). I would argue that this is not awesome for two reasons:

  1. The FailureMarker class should be fully responsible for managing the marker file.
  2. It should be excluded from all stage operations, not just the apply.

Proposed resolution

Make FailureMarker an event subscriber that listens to CollectPathsToExcludeEvent, and adds the failure marker file as an excluded path. This will also simplify StageBase::apply() a tad.

Remaining tasks

Do it and add explicit test coverage.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

Assigned: Unassigned » tedbow
Issue summary: View changes
Status: Active » Needs review
tedbow’s picture

Status: Needs review » Reviewed & tested by the community

Looks good

phenaproxima’s picture

  • phenaproxima committed 06e82f14 on 3.0.x
    Issue #3384637 by phenaproxima: FailureMarker should be responsible for...
phenaproxima’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.