Steps to reproduce

Go to content page admin/content
Edit any content for exp: /node/19/edit?destination=/en/admin/content
Now at bottom, we have Delete button, when we click on the delete button, we have spacing inconsistency.

Proposer resolution

Add margin-inline-start: 0; on .action-link link as well.

.js .action-link:not(.js-hide, .button--action) + .ajax-progress--throbber,
.js .button:not(.js-hide, .button--action) + .ajax-progress--throbber {
  margin-inline-start: 0;
}

Issue fork drupal-3384071

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Gauravvvv created an issue. See original summary.

gauravvvv’s picture

Status: Active » Needs review
snehal-chibde’s picture

Issue summary: View changes

hello, This is not replicated on Drupal 11 Claro theme.
Can you please provide any more details how this gets replicated?

yash.rode’s picture

Status: Needs review » Needs work
Issue tags: +Needs steps to reproduce

Hi @Gauravvvv, can you please provide steps to reproduce so that someone can confirm this and get it fixed.

gauravvvv’s picture

Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Needs steps to reproduce
StatusFileSize
new50.58 KB

I added the issue summary earlier, somehow it got removed. I have added it again.

yash.rode’s picture

StatusFileSize
new883.03 KB

I followed steps to reproduce with Claro theme, the throbber is spaced right for me.

gauravvvv’s picture

So the spacing with action-link button is 24px, but it should be 12px as with other buttons.
With other buttons, if we have margin-right, then we don't have margin-left on the ajax progress icon. But in case of action-link, we do have margin-right on the button and we have margin-left on the ajax progress icon also. So the margin left 12px is extra spacing here.

I have added few screenshots for better understanding.

smustgrave’s picture

Also followed the steps and not seeing the issue.

gauravvvv’s picture

I have added a screen recording as well.
In the first button, "Add Media" we have margin-right to the button and we don't have any margin-left on the ajax-progress-icon.

In the second button, "Delete" we have margin-right on the delete button additionally we have margin-left on the ajax-progress icon. That extra margin-left is the issue.

Hope it is clear now.

Harish1688’s picture

Hi,

As pr comment #10, Tested the MR !4670 for the issue spacing inconsistency in AJAX progress icon with action button (spacing between button and loader right side). found the issue on local and tested the solution given in MR, it's resolved the issue. images attached for references.

Testing Ste
1. Drupal 11.x setup and go to content page admin/content, Claro set as backend theme
2. Edit node type (Article), click on the delete button, and media button found the issue ( it's 24px, but it should be 12px).
3. Moved the MR and verified the solution, it's working fine.

Media loader spacing
issue image

Delete loader spacing Before
issue image

Delete loader spacing After patch
issue image

Looks good for RTBC+

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Per testing in #11 going to see what committers think.

nod_ made their first commit to this issue’s fork.

  • nod_ committed 513a31b9 on 11.x
    Issue #3384071 by Gauravvvv, Harish1688, yash.rode: Claro: Spacing...

  • nod_ committed 6ae2b8ff on 10.2.x
    Issue #3384071 by Gauravvvv, Harish1688, yash.rode: Claro: Spacing...
nod_’s picture

Status: Reviewed & tested by the community » Fixed

Committed 513a31b and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.