Closed (outdated)
Project:
Media Directories
Version:
2.1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Aug 2023 at 06:33 UTC
Updated:
2 Jul 2026 at 17:32 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
murphyw commentedComment #3
rang501 commentedThe hover effect should come from the core media module. We should not add any custom styling, unless absolutely necessary (and then we try to support both claro and gin), because sites may use different admin themes, which most likely will use core media classes for styling.
I remember the hover worked fine when I worked on it, but maybe something have changed and it does not work anymore?
What is the Drupal core version and what is the admin theme?
Comment #4
murphyw commenteddrupal core 10.1 and admin theme is seven
Comment #5
murphyw commentedIn the previous version of drupal 9.5, it was normal for the media_directories version to be 2.0, which may be a theme problem.
Comment #6
rang501 commentedI think seven is not supported at the moment. Because the media directories is using core media module classes and styling, it should work, unless theme does something differently, like alters markup or classes, which does not affect media directories.
Maybe there is a separate js file that does the hover effect? Maybe you need to include that instead? The library definitions are theme specific and I guess seven library is not included.
Comment #7
murphyw commentedI also think it is a problem with the seven theme
Comment #8
murphyw commentedSorry for the sloppy way I went about it, I just wanted to get things done quickly.
I am so sorry
Comment #9
gomez_in_the_south commentedI'm also using Drupal 10.1.x, whilst still staying on Seven theme (for now).
The Media directories UI with the Seven admin theme appears completely broken, the size of the thumbnails was wrong, there was no tiling, and it wasn't useable.
I came to a similar solution to murphyW, adapting some of the styling rules from the previous version, and hacked a few other CSS overrides to get it to appear close to how it did before.
I only found murphyW's patch afterwards, which I have found fixes some, but not all of the styling issues I was finding. As such, I thought it worthwhile to still attach my version, in case it helps anyone else in a similar situation.
It's important to note that both patches attached to this issues are a temporary solution, and anyone using either one should:
- only use it if you're on the Seven theme (or want to see if it helps an issue with another legacy theme)
- not expect this to be merged
- plan to upgrade to Claro/Gin or similar in the near future
Perhaps the maintainers should change the status of this issue to "Won't fix"?
Comment #10
ytsurkWe actually did not want to remove support for seven already now.
Comment #11
rang501 commentedI made some changes that seem to fix Seven theme support. It just includes the libraries in the required places.
Comment #12
ytsurkThank you rang501, but where are these changes?
Comment #13
rang501 commentedIt was quite late and I guess I forgot :D
Comment #14
adinancenci commentedPatch 11 did not worked for me.
You see, I am using adminimal which is based on seven.
Maybe the patch could be modified to be used on themes based on seven.
Comment #15
adinancenci commentedHello again, I made some slight modifications to the previous patch to take the base theme in consideration as well:
Comment #16
ckngRerolled with a fix as Claro base theme is `false`.
Comment #17
ckngIncorrect patch, updated.
Comment #18
ytsurkThank you for your work.
Seems like we're doing here the same thing three times, can't this be en-capsuled in a helper function?
Comment #19
rang501 commentedNot supported version anymore. Most likely is fixed in 3.x. Closing as outdated.