Comments

murphyW created an issue. See original summary.

murphyw’s picture

StatusFileSize
new1.35 KB
rang501’s picture

The hover effect should come from the core media module. We should not add any custom styling, unless absolutely necessary (and then we try to support both claro and gin), because sites may use different admin themes, which most likely will use core media classes for styling.

I remember the hover worked fine when I worked on it, but maybe something have changed and it does not work anymore?

What is the Drupal core version and what is the admin theme?

murphyw’s picture

drupal core 10.1 and admin theme is seven

murphyw’s picture

In the previous version of drupal 9.5, it was normal for the media_directories version to be 2.0, which may be a theme problem.

rang501’s picture

I think seven is not supported at the moment. Because the media directories is using core media module classes and styling, it should work, unless theme does something differently, like alters markup or classes, which does not affect media directories.

Maybe there is a separate js file that does the hover effect? Maybe you need to include that instead? The library definitions are theme specific and I guess seven library is not included.

murphyw’s picture

I also think it is a problem with the seven theme

murphyw’s picture

Sorry for the sloppy way I went about it, I just wanted to get things done quickly.
I am so sorry

gomez_in_the_south’s picture

I'm also using Drupal 10.1.x, whilst still staying on Seven theme (for now).
The Media directories UI with the Seven admin theme appears completely broken, the size of the thumbnails was wrong, there was no tiling, and it wasn't useable.

I came to a similar solution to murphyW, adapting some of the styling rules from the previous version, and hacked a few other CSS overrides to get it to appear close to how it did before.

I only found murphyW's patch afterwards, which I have found fixes some, but not all of the styling issues I was finding. As such, I thought it worthwhile to still attach my version, in case it helps anyone else in a similar situation.

It's important to note that both patches attached to this issues are a temporary solution, and anyone using either one should:
- only use it if you're on the Seven theme (or want to see if it helps an issue with another legacy theme)
- not expect this to be merged
- plan to upgrade to Claro/Gin or similar in the near future

Perhaps the maintainers should change the status of this issue to "Won't fix"?

ytsurk’s picture

Assigned: murphyw » Unassigned
Status: Active » Needs review

We actually did not want to remove support for seven already now.

rang501’s picture

I made some changes that seem to fix Seven theme support. It just includes the libraries in the required places.

ytsurk’s picture

Thank you rang501, but where are these changes?

rang501’s picture

StatusFileSize
new2.09 KB

It was quite late and I guess I forgot :D

adinancenci’s picture

Patch 11 did not worked for me.

You see, I am using adminimal which is based on seven.

Maybe the patch could be modified to be used on themes based on seven.

adinancenci’s picture

StatusFileSize
new4.32 KB

Hello again, I made some slight modifications to the previous patch to take the base theme in consideration as well:

ckng’s picture

Version: 2.1.0-beta2 » 2.1.x-dev
StatusFileSize
new4.37 KB

Rerolled with a fix as Claro base theme is `false`.

ckng’s picture

StatusFileSize
new4.56 KB

Incorrect patch, updated.

ytsurk’s picture

Thank you for your work.

Seems like we're doing here the same thing three times, can't this be en-capsuled in a helper function?

rang501’s picture

Status: Needs review » Closed (outdated)

Not supported version anymore. Most likely is fixed in 3.x. Closing as outdated.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.