Problem/Motivation

Readme.md file missing in the module. It helps developers to understand the module.

Proposed resolution

Create a Readme.md file.

For reference using this documentation about README.md template

CommentFileSizeAuthor
#13 readme_2.png129.73 KBtanuja bohra
#13 readme_1.png143.81 KBtanuja bohra
#6 word-wrap.jpg29.79 KBpriya_degwekar
#3 3383644.patch1.29 KBpriya_degwekar

Issue fork full_screen_mode-3383644

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Priya_Degwekar created an issue. See original summary.

priya_degwekar’s picture

priya_degwekar commented
Assigned: Unassigned » priya_degwekar
priya_degwekar’s picture

priya_degwekar commented
Assigned: priya_degwekar » Unassigned
Status: Active » Needs review
StatusFileSize
new 3383644.patch1.29 KB

I have created a patch.
Please review.

dawadorjidd’s picture

dawadorjidd commented
Status: Needs review » Needs work

Hello @Priya_Degwekar I have applied your patch for the same. The patch is applied successfully but the characters exceed more than 80col for line 3 and 26.

priya_degwekar’s picture

priya_degwekar commented
Assigned: Unassigned » priya_degwekar

Ok.. I will work on it.

priya_degwekar’s picture

priya_degwekar commented
StatusFileSize
new word-wrap.jpg29.79 KB

Hi, @dawadorjidd, I think characters are not exceeding more than 80col at my end.
Please check the screenshot.
If you can able to correct it, Please do the corrections.
Thanks.

priya_degwekar’s picture

priya_degwekar commented
Assigned: priya_degwekar » Unassigned

elber made their first commit to this issue’s fork.

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented
Status: Needs work » Needs review

elber opened merge request !1

tanuja bohra’s picture

tanuja bohra commented

@elber, from the introduction section, a link to the project page and issue queue is missing.

example -> For a full description of the module, visit the
[project page](https://www.drupal.org/project/admin_menu).

Submit bug reports and feature suggestions, or track changes in the
[issue queue](https://www.drupal.org/project/issues/admin_menu).

elber’s picture

elber
Primary language Portuguese, Brazil
Location Brazil
commented

Hi Tanuja Bohra I fixed it, please revise

tanuja bohra’s picture

tanuja bohra commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new readme_1.png143.81 KB
new readme_2.png129.73 KB

Thanks @elber, the MR1 is cleanly applied. Added screenshots for reference, RTBC++

sujan shrestha’s picture

sujan shrestha commented
Version: 1.1.0 » 1.1.4
Status: Reviewed & tested by the community » Fixed

The previously missing README.md file has now been created. Thank you all for your valuable feedback.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.