Problem/Motivation

HEAD of 4.x tests have been failing since around D9.x something
review this now that we're onto D10 and beyond.

Steps to reproduce

review test results

Proposed resolution

commit these:
To fix the automated testing, two patches are ready:

#3405276: Panels IPE "placement" form for new blocks not loading in Drupal 10
and
#2636472: Load context for page that IPE is editing, rather than AJAX or form route

Remaining tasks

see proposed solution

User interface changes

TBD

API changes

TBD

Data model changes

TBD

CommentFileSizeAuthor
#12 panels_ipe-3383474-12.patch1.53 KBjoseph.olstad
#10 panels_ipe-3383474-10.patch1.56 KBjoseph.olstad
#6 panels_ipe-explicit_support-3383474-06.patch4.54 KBjoseph.olstad
#2 panels_ipe-explicit_support-3383474-02.patch825 bytesjoseph.olstad

Issue fork panels-3383474

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new panels_ipe-explicit_support-3383474-02.patch825 bytes

see if this helps

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

https://www.drupal.org/node/3168858

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

drupalPostForm() in functional tests is deprecated

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new panels_ipe-explicit_support-3383474-06.patch4.54 KB
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: Fix HEAD test failures for 4.x branch possibly related to recent core or ctools changes » Fix HEAD test failures - drupalPostForm() in functional tests is deprecated
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: Fix HEAD test failures - drupalPostForm() in functional tests is deprecated » Fix HEAD test failures for 4.x
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new panels_ipe-3383474-10.patch1.56 KB

Oops that was 3x, here's 4x

I was confused

Status: Needs review » Needs work

The last submitted patch, 10: panels_ipe-3383474-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Needs review
StatusFileSize
new panels_ipe-3383474-12.patch1.53 KB

encore mieux

Status: Needs review » Needs work

The last submitted patch, 12: panels_ipe-3383474-12.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

While it is incomplete, I think it's worthy of commit as it's improving the results.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Needs review

Thanks for taking on the test failures @joseph.olstad. I've committed this WIP.

I'll leave this open in case you have some ideas on the IPE errors.

Liam Morland made their first commit to this issue’s fork.

Liam Morland opened merge request !17

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Created a merge request that adds the default .gitlab-ci.yml.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Parent issue: » #3405276: Panels IPE "placement" form for new blocks not loading in Drupal 10
Related issues: +#2636472: Load context for page that IPE is editing, rather than AJAX or form route

To fix the automated testing, two patches are ready:

#3405276: Panels IPE "placement" form for new blocks not loading in Drupal 10
Merge request

and
#2636472: Load context for page that IPE is editing, rather than AJAX or form route
patch #16

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Reviewed & tested by the community

joseph.olstad opened merge request !19

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Reviewed & tested by the community » Needs review

  • joseph.olstad committed a7652be2 on 8.x-4.x 
    Issue #3383474 by joseph.olstad, Liam Morland, joelpittet: Fix HEAD test...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

I have committed the changes, I'll see how that affects it all before releasing the changes.

xem8vfdh’s picture

xem8vfdh commented

amazing, thanks!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

I note that tests are still failing even with these changes.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#3450740: Fix HEAD tests Tests: 35, Errors: 1, Failures: 3.