Problem/Motivation

As (soon to be) discovered by mglaman/phpstan-drupal 1.2.0 (see #3383279: Bump mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again), we are using some deprecated functionality throughout Drupal core.

This issue is for dealing with:

 ------ ----------------------------------------------------------------- 
  Line   core/modules/media/tests/src/Kernel/EditorMediaDialogTest.php    
 ------ ----------------------------------------------------------------- 
  88     Call to method create() of deprecated class                      
         Drupal\media\Form\EditorMediaDialog:                             
         in drupal:10.1.0 and is removed from drupal:11.0.0. There is no  
         replacement.                                                     
 ------ -----------------------------------------------------------------

Note: Depending on the landing of #3383279: Bump mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again before the landing of this issue, we also might need to remove a suppression from core/phpstan-baseline.neon

Steps to reproduce

Proposed resolution

Add @group legacy to EditorMediaDialogTest, which seems we have missed in #3231341: Deprecate EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 10.1 for removal in Drupal 11.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3383367

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Title: Replace deprecated call to deprecated method registerLoader() of class Doctrine\Common\Annotations\AnnotationRegistry » Add @group legacy to EditorMediaDialogTest

Spokje opened merge request !4645

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented

Minor change LGTM

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Related issues: +#3231341: Deprecate EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal 10.1 for removal in Drupal 11
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Will need a re-roll after #3383339: Replace implementing deprecated interface Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface with ValueResolverInterface

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Rerolled with PHPStan baseline suppression removed and re-RTBC-ed, since there were no code changes.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes

  • catch committed 97f1d6b0 on 11.x 
    Issue #3383367 by Spokje: Add @group legacy to EditorMediaDialogTest
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 97f1d6b and pushed to 11.x. Thanks!

Spokje closed merge request !4645

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.