Problem/Motivation

  1. RSS feed block on the smaller screen is not placed as per design. The icon is placed on the right side and the text is placed on the left side in the Olivero theme but in design the placement is different. See in design, attaching design link here - https://www.figma.com/file/x5zBLbvoW1jsvyAOt4Gp9I/Olivero-Theme---Public...
  2. The second issue is - the icon and text are not aligned, see screenshot2
  3. Third issue is - Icon has border-radius in design but in Olivero theme radius is missing

Steps to reproduce

  1. Set up the Drupal site, and moved on Olivero theme.
  2. Switch on a smaller screen (Below 768px)
  3. See the RSS feed block at the bottom

Proposed resolution

Need to style as per the design

Remaining tasks

User interface changes

Before:

After:

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 Screenshot 2023-09-03 at 12.09.35 PM.png8.07 KBlauriii
#10 Screenshot 2023-09-03 at 12.08.35 PM.png8.23 KBlauriii
#6 interdiff_5-6.txt998 bytesshweta__sharma
#6 3382843-6.patch1.58 KBshweta__sharma
#5 interdiff_3-5.txt878 bytesshweta__sharma
#5 Added-border-radius-to-icon-3382843-5.patch1.54 KBshweta__sharma
#5 after-patch.png256.96 KBshweta__sharma
#3 3382843-3.patch1.22 KBgauravvvv
#3 afterpatch.png64.32 KBgauravvvv
screenshot2.png251.07 KBshweta__sharma
screenshot1.png209.61 KBshweta__sharma

Issue fork drupal-3382843

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

shweta__sharma created an issue. See original summary.

shweta__sharma’s picture

shweta__sharma commented
Issue summary: View changes
gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new afterpatch.png64.32 KB
new 3382843-3.patch1.22 KB

I have attached a patch for same, Also attached after patch screenshot for reference. please review

After Patch

smustgrave’s picture

smustgrave commented
Issue tags: +Needs subsystem maintainer review
shweta__sharma’s picture

shweta__sharma commented
StatusFileSize
new after-patch.png256.96 KB
new Added-border-radius-to-icon-3382843-5.patch1.54 KB
new interdiff_3-5.txt878 bytes

Applied #3 patch and it is working fine, the feed block is now as per design. Added a screenshot for reference, also I provided the patch for the third point which is related to border-radius, please review.
Thanks

shweta__sharma’s picture

shweta__sharma commented
StatusFileSize
new 3382843-6.patch1.58 KB
new interdiff_5-6.txt998 bytes

Fixed the #5 error.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs subsystem maintainer review

This is actually a small tweak I don't think needs submaintainer review.

Think it's good for committer review.

quietone’s picture

quietone commented

I tested this on Drupal 11.x and didn't notice any difference before and after the patch. Can someone upload a before image?

  • lauriii committed 08f6d675 on 11.x 
    Issue #3382843 by shweta__sharma, Gauravvvv, smustgrave: Olivero: RSS...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 10.1.x-dev » 11.x-dev
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed
Issue tags: -rss feed
StatusFileSize
new Screenshot 2023-09-03 at 12.08.35 PM.png8.23 KB
new Screenshot 2023-09-03 at 12.09.35 PM.png8.07 KB

Added before and after screenshots to issue summary.

Committed 08f6d67 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.