Problem/Motivation

Due to additional functions for sorting in #3311231: Sorting and sort boost the original functions now have imprecise names.

Remaining tasks

src/Api/MeiliSearchApiServiceInterface.php imprecisely defines "setSettings" and "getSettings".
This is not semantically correct, as they don't update all settings but just the filterable attributes. They (and calls to them) should probably be renamed to e.g. "setFilterableAttributes".

Issue fork search_api_meilisearch-3382618

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tgoeg created an issue. See original summary.

elber made their first commit to this issue’s fork.

bcizej’s picture

bcizej commented
Issue summary: View changes

elber opened merge request !14

elber opened merge request !15

elber closed merge request !14

elber reopened merge request !14

elber closed merge request !14

bcizej reopened merge request !14

bcizej closed merge request !15

bcizej’s picture

bcizej commented
Status: Active » Needs review

I have renamed the methods and also added general getSettings and setSettings methods so that the entire index settings can be retrieved or set.

Ready for review.

DeaOm made their first commit to this issue’s fork.

deaom’s picture

deaom commented

Tested the changed code and everything works fine. Did see the change to use camelCase for variables, so decided to change it also here for all the variables that were not changed for consistency (did not see a point in opening another issues for that). So leaving the status to needs review, but from my point of view, can be merged.

  • bcizej committed f876fc94 on 1.0.x authored by elber 
    Issue #3382618 by bcizej, elber, DeaOm, tgoeg: Rename...
bcizej’s picture

bcizej commented
Status: Needs review » Fixed

Merged, thanks everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.