Hello all, it’s time for the biweekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every second Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

Core migration issues

Next video meeting TBD

0️⃣ Who is here today?

mikelutz (he/him) morning
Stephanie here, mainly lurking.
Dan Davis Here
heddn Lucas here
quietone Catching up

1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.

mikelutz (he/him) Lots of migrate stuff stuck in RTBC, not sure what we can do about that.
quietone Yes, several committers have been on holiday

2️⃣ Action items. To be added later.

3️⃣ Statistics

benjifisher Fixed in the last 2 weeks: 1 (not counting issues for meetings).
benjifisher RTBC: 14, 2 of which are Major and 1 has not been updated in more than 1 month.
benjifisher NR: 2, all Normal, and 1 that has not been updated in more than 1 month.
benjifisher Needs subsystem maintainer review: 6
benjifisher Google sheet for recording stats: https://docs.google.com/spreadsheets/d/1o0Rjlc1vnnLP5bM5P-SMMyGzqn7258hi...
benjifisher I know that @quietone has been triaging the RTBC issues. If we do not count the triage comments, then some of the RTBC issues have been waiting longer.
heddn we're missing committers. hopefully they are more available in the next couple weeks.
heddn not much we can do but wait
quietone Yeah. What we can do is make sure that the issue is really ready for commit. to use an English idiom, "dot the i's and cross the t's"

4️⃣ Comment in this thread if you are looking for ways to contribute. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...

5️⃣ Previous minutes.

benjifisher We have a backlog here. Would anyone like to volunteer to post transcripts to the issues?
Dan Davis How many meetings? I can work on it right now, if you have the transcript documents and can give me a quick intro.
benjifisher Sorry, I did not see this earlier.
benjifisher First step is do install https://github.com/mdlutz24/drupal-meeting-parser (Chrome or Chromium only).
benjifisher I do not copy the "It's time" post. I start with 0️⃣ (Who is here today) but choose the "add without credit" option. For all the other threads, I use "add with credit".
benjifisher You could start with the issue for the previous meeting: #3381771: [meeting] Migrate Meeting 2023-08-17 2100Z. If you have time and patience to do more, follow the "Parent meeting" link to the issue for the previous meeting. Keep going as long as you are willing, or until you find one that already has a transcript.
Dan Davis @benjifisher do I paste the result into a comment, or the issue description?
benjifisher issue summary
benjifisher Example: #3376389: [meeting] Migrate Meeting 2023-07-27 2100Z
Dan Davis Can you review my work please? https://www.drupal.org/project/drupal/issues/3381771#comment-15213684
Dan Davis @benjifisher as I am not currently a maintainer, I could not add the individual credits on the issue. I included the participant list at the end of the summary.
benjifisher Thanks! I will review later in the day.
Dan Davis @benjifisher let me know if any changes are needed, or if you wanted me to upload additional meeting notes.

6️⃣ Announcements

benjifisher https://www.drupal.org/about/drupal-7/d7eol/partners is now live, and in the menu (Resources > Drupal 7 Migrations). More than a dozen companies have signed up as "Migration Partners".

7️⃣ Consolidate code in the migrate_drupal module. (edited) 

benjifisher I have set myself a deadline of Drupal 10.2 to make progress here. At least review @quietone’s work on #3332998: Move migration code from content_translation to migrate_drupal. But not this week. :disappointed:
quietone I think we should postpone this on getting approval from release managers/committer team on the deprecation path. (edited)
quietone While I have enjoyed working on this and it's sibling I have postponed them. Unlike other module removals there is a significant amount of work here so I think it is prudent to be sure there is consensus on the removal path.

8️⃣ Allow process plugins to flag a row to be skipped

benjifisher #3247718: Allow process plugins to flag a row to be skipped
benjifisher I have a train ride coming up tomorrow (and a return trip on Sunday). I will have a spotty internet connection, but I should be able to review this issue.
mikelutz (he/him) I’d love a review on that from someone at some point.

9️⃣ The RTBC queue is growing.

benjifisher @quietone: You have been triaging the RTBC issues. For example, I saw your comments on #3063856: Add ability to view migrate_message table data (and thanks for the shout-out there).
benjifisher What can we expect from the triage process, and is there anything we can do to help move these along?
mikelutz (he/him) I’m curious if @quietone can help move some of these along.  Usually Alex Pott takes care of these, but I’m not sure what has happened to him.  Last I saw he was taking a 3 week holiday in May, but I haven’t seen him on slack or the issue queue since.
benjifisher I notice that @longwave has been committing some migration issues.
longwave i have been trying to clear down the RTBC queue and migration issues are indeed some part of that 🙂 i have tended to pick the smaller ones that i fully understand but also will take a stab at larger issues where i can
longwave alexpott has taken the entire summer off but i believe he is due back soon
mikelutz (he/him) I'm glad to hear its just a planned holiday. He deserves it.
longwave if there are any criticals or blockers that are RTBC and commit would help unblock progress elsewhere, feel free to ping me with details any time

1️⃣0️⃣ Needs Maintainer Response

benjifisher Under 3️⃣, I mentioned that there are 6 of these. Can we handle one or two during this meeting?
benjifisher From oldest to newest (by last comment) ...
benjifisher #3118262: Calling EntityConfig::import() with multiple destination IDs fails
benjifisher #3108302: [PP-2] Field formatter & widget settings: fall back to default if missing plugin
benjifisher #3096972: The Drupal 7 ThemeSettings source plugin does not check that the destination site has a valid theme to migrate settings into
benjifisher #3036368: No messages after the migration.
benjifisher #3051251: Existing menu links show validation issues on migration (and ALL menu links pointing to node translations are invalid)
benjifisher #3204212: Convert remaining widget and formatter type migrations to MigrateField plugins
benjifisher I am looking at #3096972. The tag was added in #21. There is as specific question about Comment 18.1. (Comment#21 says 18.2, but I think that is off by one.)
benjifisher The question is about the d6_block migration:

We shouldn't migrate block configs whose theme dependency is unavailable. To be able to test this somehow (the single bluemarine block in the Drupal 6 fixture should be skipped), I changed the way how the pre-existing block config ids are calculated.

This means that from this point, block configurations which are migrated from Drupal 6 will get an id that is prefixed with the target theme's machine name.

Migrate maintainers, please examine whether this change is acceptable or not
benjifisher What is our BC policy for migration plugins (YAML)?
benjifisher The migrated block config is currently something like aggregator, aggregator_1, etc. (It uses the make_unique_entity_field plugin.) The issue wants to change that to something like bartik_aggregator (and still append _1 if needed, but presumably it will not be needed as much).
benjifisher @heddn and @quietone already commented on the issue, and raised other BC concerns, but did not address this particular one.
heddn there's an issue for deprecation of BC of migration yaml plugins. right now, it seems to be a case by case basis
benjifisher From my brief look at the issue during the meeting, my initial opinion is that we should not break BC here if it is just a related improvement. If it is needed for the rest of the patch to work, then maybe.

1️⃣1️⃣ Wrap up

benjifisher Thanks for participating! I will update 2️⃣. Please continue to add comments in the threads. In 1-7 days, we will post a transcript for today's meeting.

Comments

benjifisher created an issue. See original summary.

dinarcon’s picture

dinarcon commented

In case I am not able to join the next meeting in real time, I would like to propose we add a thread to talk about about this issue #2797505: Migrations fail due to missing dependency when dependency has skipped rows by the source plugin

benjifisher credited heddn.

benjifisher credited longwave.

benjifisher credited mikelutz.

benjifisher credited quietone.

benjifisher’s picture

benjifisher
he/him or they/them
Primary language English
Location Boston area
commented
Issue summary: View changes
Status: Active » Needs review

smustgrave credited ddavisboxleitner.

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Went into slack and reviewed 8/31 threads. All threads have been captured and users credited, added ddavisboxleitner for his help in #5

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.