Problem/Motivation

Currently this module requires schema_metatag version ^2 while it's not compatible with the latest ^3 version and this could block the update path of other related modules like schema_metatag and metatag.

Steps to reproduce

Try to update metatag module to its latest version ^2 and/or schema_metatag to its latest version ^3 and you'll get an error caused by schema_publication_issue not supporting these versions.

Proposed resolution

Update the dependency for this module, so it could also support higher versions of schema_metatag.

CommentFileSizeAuthor
#9 3381024-9.patch364 bytesvuil
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

RumenDamyanov created an issue. See original summary.

elber made their first commit to this issue’s fork.

elber’s picture

Status: Active » Needs review
rumenx’s picture

Status: Needs review » Reviewed & tested by the community

I tested the changes from the issue fork above without any problems.

elber’s picture

Hi @RumenDamyanov thank you for your patch but it is not related to this issue, you should open another issue specific to add a composer.json file

rumenx’s picture

Please, don't remove the composer.json file from the repo as it's required from composer to be able to install the package from the issue fork repo instead of the original package repo. If the file is missing you'll get an error:
No valid composer.json was found in any branch or tag of https://git.drupalcode.org/issue/schema_publication_issue-3381024.git, could not load a package from it.

vuil’s picture

Status: Reviewed & tested by the community » Active
vuil’s picture

Status: Active » Needs review
StatusFileSize
new364 bytes

  • vuil committed 4f38d748 on 1.0.x
    Issue #3381024 by elber, RumenDamyanov, vuil: Compatibility with '...
vuil’s picture

Status: Needs review » Fixed

I close the issue as Done.
@Rumen please open an additional issue about the missing composer.json and post it there. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.