Problem/Motivation

My local installation implements a patch from #2968609: Link fields do not check access for entity refs which makes changes to the upstream LinkFormatter's constructor, which in turn breaks the current LinkitFormatter.

Steps to reproduce

Apply the #2968609: Link fields do not check access for entity refs patch and attempt to make use of the LinkitFormatter. It'll be missing a mandator constructor argument.

Proposed resolution

Ensure that the parent LinkFormatter is fully instantiated before adding new properties to it.

Remaining tasks

Provide issue fork/patch.

User interface changes

N/A

API changes

N/A

Issue fork linkit-3379928

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

codebymikey created an issue. See original summary.

codebymikey’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new3.29 KB
mark_fullmer’s picture

This generally makes sense, and will simplify the constructor for the LinkitFormatter, and tests pass. Adding test for 6.0.x (Drupal 10.0.x and below).

  • mark_fullmer committed 6e6e6f9d on 6.1.x
    Issue #3379928 by codebymikey, mark_fullmer: Support upstream changes to...

  • mark_fullmer committed 1ce023ed on 6.0.x
    Issue #3379928 by codebymikey, mark_fullmer: Support upstream changes to...
mark_fullmer’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.