Problem/Motivation

Just removing please per the Style section of the User interface standards.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
remove-please.patch10.77 KBquietone

Comments

quietone created an issue. See original summary.

keshavv’s picture

keshavv commented
Status: Active » Reviewed & tested by the community

The patch works well, So if we need to remove the please word from sentences.
We can merge it.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Reviewed & tested by the community » Needs review 
+++ b/tests/src/Functional/StagedDatabaseUpdateTest.php
@@ -102,7 +102,7 @@ class StagedDatabaseUpdateTest extends UpdaterFormTestBase {
+    $assert_session->pageTextContainsOnce('Continue to the error page');

Maybe this comes from core. So will have to see if tests pass

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Tests appear to pass, so this seems good to go.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 3.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.