Problem/Motivation

The function swapDumper() in the class FlysystemServiceProvider() current returns and prevents swapping of Drupal\flysystem\Asset\CssOptimizer, when the scheme is "public". However, the Settings for "file_additional_public_schemes" should also be supposed, if a value for "file_additional_public_schemes" is set.

Steps to reproduce

Turn on CSS aggregation and broken url() attributes within the CSS will occur, since the url() should be loaded from the site's base URL< and not the flysystem URL (e.g., Amazon S3).

Proposed resolution

Apply patch to support "file_additional_public_schemes".

CommentFileSizeAuthor
#6 3379832-3.patch799 bytesshefik
#2 3379832.patch903 bytesshefik

Issue fork flysystem-3379832

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Shefik created an issue. See original summary.

shefik’s picture

shefik commented
StatusFileSize
new 3379832.patch903 bytes

Modify the file /modules/contrib/flysystem/src/FlysystemServiceProvider.php to apply the patch.

shefik’s picture

shefik commented
shefik’s picture

shefik commented
Version: 3.0.x-dev » 2.1.x-dev
lisa.rae’s picture

lisa.rae commented
Status: Active » Needs work
shefik’s picture

shefik commented
StatusFileSize
new 3379832-3.patch799 bytes

Patch is updated to apply correctly.

lisa.rae’s picture

lisa.rae commented
Version: 2.1.x-dev » 2.3.x-dev

lhridley changed the visibility of the branch 3379832-flysystemserviceproviderswapdumper-needs-to to hidden.

lhridley opened merge request !64

lisa.rae’s picture

lisa.rae commented
Status: Needs work » Needs review

  • lhridley committed 6d9c68bb on 2.3.x 
    Issue #3379832 by shefik, lhridley: FlysystemServiceProvider::swapDumper...
lisa.rae’s picture

lisa.rae commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

lisa.rae’s picture

lisa.rae commented
Version: 2.3.x-dev » 2.2.x-dev
Assigned: Unassigned » lisa.rae
Status: Closed (fixed) » Needs work
lisa.rae’s picture

lisa.rae commented
Status: Needs work » Patch (to be ported)

lisa.rae changed the visibility of the branch 3379832-flysystemserviceproviderswapdumper-needs-to to active.

  • lisa.rae committed 4d2460cd on 2.2.x 
    Issue #3379832 by shefik, lisa.rae: FlysystemServiceProvider::swapDumper...
lisa.rae’s picture

lisa.rae commented
Status: Patch (to be ported) » Fixed

Patch ported and merged into 2.2.x branch. Closing issue as fixed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.