Steps to reproduce.
Install Umami profile
Uninstall SDC module

The following error appear on all site pages.

Twig\Error\LoaderError: Template "umami:branding" is not defined.

Issue fork drupal-3379430

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Chi created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Related issues: +#3379355: Updating drupal core from 10.1.1 to 10.1.2 breaks Unami site

nlisgo made their first commit to this issue’s fork.

nlisgo opened merge request !4547

nlisgo’s picture

nlisgo commented
Status: Active » Needs review

From your comments on the related issue I'm assuming no test in needed here. But introducing the first dependency feels a little strange. What other modules, if uninstalled, would cause an error with demo_umami?

sdc is also an experimental module but this might actually be a bug with sdc? Shouldn't uninstalling sdc result in the single directory components failing more gracefully?

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Yea could see if someone didn't know what sdc was used for they could uninstall and definitely cause issues.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs work

kostyashupenko made their first commit to this issue’s fork.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Remarking.

  • lauriii committed 99e0bb6c on 11.x 
    Issue #3379430 by nlisgo, kostyashupenko, Chi, smustgrave: Umami theme...

lauriii closed merge request !4547

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed 99e0bb6 and pushed to 11.x. Thanks!

  • lauriii committed 6bccf5b0 on 10.1.x 
    Issue #3379430 by nlisgo, kostyashupenko, Chi, smustgrave: Umami theme...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 11.x-dev » 10.1.x-dev

Cherry-picked to 10.1.x since Umami is experimental/internal.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.