Add the "Show Blocks" functionality that existed in CKEditor 4 and was added to CKEditor 5 38.1.0

Currently created contrib module to support
https://www.drupal.org/project/ckeditor5_show_block

I’ve been trying for 30 mins now and am failing HARD at getting it to be installed into Drupal 😳

git clone https://git.drupalcode.org/project/drupal.git
cd drupal/core
yarn add @ckeditor/ckeditor5-show-blocks@38.1.0
yarn build

If you then do a git diff you’ll see that nothing was added to core/assets/vendor 🤯😱

Escalated to CKEditor 5 team, and:

Witek Socha
2 hours ago
:open_mouth:

Witek Socha
2 hours ago
shoot, there’s no DLL build there :exploding_head: https://www.npmjs.com/package/@ckeditor/ckeditor5-show-blocks?activeTab=...

Witek Socha
2 hours ago
escalating…

So this is blocked on an upstream fix 😇

A patch release for version 39 of CKEditor 5 will ship later this week, and it'll provide the required DLL build 👍

Fixed in 39.0.1, which is in core since #3380637: Update CKEditor 5 to 39.0.1! 👍

This is ready for review!

Green! 😊

Tested this on 11.x

It seems to pick up all the regular tags, ul, ol, p, a, etc. But if I use a media embed or anything nothing appears. Know that probably wasn't on the list upstream but could the plugin we expanded for drupal?

If not don't think it's the end of the world.

Tagging for CR for the new plugin option though.

Very interesting 🧐

Per https://ckeditor.com/docs/ckeditor5/latest/features/show-blocks.html#kno...

The show blocks feature does not support widgets, yet. It means it will currently not show block outlines e.g. for images or tables.

— Drupal Media is an example of that.

Asked the CKEditor 5 team about this 🤓

Could you perhaps post a screenshot of what it looks like when using Drupal Media as well as a custom HTML tag such as foobar, as well as a non-custom HTML tag that is not natively supported such as <hr>? 🙏

Sure

Re-roll for drupal 9.5.x

Re-roll patch for Drupal 9.5.x to be working with https://www.drupal.org/project/drupal/issues/3362414

#20 fails to apply to Drupal 10.1.3.

@mikesimmons: The MR still applies cleanly to Drupal 11.x.

The patches in #18, #19 and #20 are only provided to get this on earlier Drupal versions.

Still awaiting response to #16.

Thanks for pointing out the MR, @wim-leers.
Here a patch for Drupal 10.1.3.

I wrote in #16:

Asked the CKEditor 5 team about this 🤓

They just created an issue for this to measure community interest in this: https://github.com/ckeditor/ckeditor5/issues/14869

• Change record created: https://www.drupal.org/node/3388811
• Manual testing was done by @smustgrave in #15.

Retested and still seeing the outline around ul, ol, p, a, etc. Assuming if the media fix happens it will be upstream so nothing to do here.

Correct — there shouldn't be anything needed on our end to support widgets like DrupalMedia's 👍

Committed 116c87e and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!