Problem/Motivation

PHP Compatibility issue, this test has probably never worked in its current implementation.

FILE: ...b/flysystem/tests/src/Unit/Plugin/FlysystemPluginManagerTest.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 38 | ERROR | Using a call-time pass-by-reference is deprecated since
    |       | PHP 5.3 and prohibited since PHP 5.4
----------------------------------------------------------------------

Issue fork flysystem-3378461

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lhridley created an issue. See original summary.

keshav.k made their first commit to this issue’s fork.

keshav.k opened merge request !30

keshavv’s picture

keshavv commented
Status: Active » Needs review

I have created the MR !30.
Please review.
Thank you.

roshni27’s picture

roshni27 commented

I have review code. its looks correct.
+1 RTBC

lisa.rae’s picture

lisa.rae commented

Needs work, this code change resulted in 2 failing tests.

This test is testing a class method that has variables that are passed by reference (`Drupal\flysystem\Plugin\FlysystemPluginManager::alterDefinitions`). `Drupal\flysystem\FlysystemPluingManager` extends `Drupal\Core\Plugin\DefaultPluginManager` and overrides the `alterDefinitions` method on that class. As extension, this class needs to maintain the API definition of the parent class, which receives parameters passed by reference.

lisa.rae’s picture

lisa.rae commented
Status: Needs review » Needs work
lisa.rae’s picture

lisa.rae commented
Status: Needs work » Closed (outdated)
Issue tags: -

Closing as outdated, Flysystem 2.1.0+ is no longer supported, and upgrading to a supported version is recommended.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.