Problem/Motivation

Fix some general problems spotted in recent development

Proposed resolution

  1. Use Subscriber::subscribe() instead of SubsciptionManager::subscribe() where possible
  2. Use get() rather than magic properties
  3. Fix typos and bad English
  4. Use Subscriber::isSubscribed() instead of getSubscription() where possible

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 simplenews.tidy_.3378271-interdiff-6-7.txt1.24 KBadamps
#7 simplenews.tidy_.3378271-7.patch16.89 KBadamps
#6 simplenews.tidy_.3378271-interdiff-4-6.txt2.79 KBadamps
#6 simplenews.tidy_.3378271-6.patch16.91 KBadamps
#4 simplenews.tidy_.3378271-interdiff-2-4.txt1.48 KBadamps
#4 simplenews.tidy_.3378271-4.patch16.19 KBadamps
#2 simplenews.tidy_.3378271-2.patch15.62 KBadamps

Comments

AdamPS created an issue. See original summary.

adamps’s picture

adamps commented
Status: Active » Needs review
StatusFileSize
new simplenews.tidy_.3378271-2.patch15.62 KB

Status: Needs review » Needs work

The last submitted patch, 2: simplenews.tidy_.3378271-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new simplenews.tidy_.3378271-4.patch16.19 KB
new simplenews.tidy_.3378271-interdiff-2-4.txt1.48 KB

Status: Needs review » Needs work

The last submitted patch, 4: simplenews.tidy_.3378271-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new simplenews.tidy_.3378271-6.patch16.91 KB
new simplenews.tidy_.3378271-interdiff-4-6.txt2.79 KB
adamps’s picture

adamps commented
StatusFileSize
new simplenews.tidy_.3378271-7.patch16.89 KB
new simplenews.tidy_.3378271-interdiff-6-7.txt1.24 KB
adamps’s picture

adamps commented

  • AdamPS committed f82ea986 on 4.x 
    Issue #3378271 by AdamPS: Minor tidy up and code improvements
adamps’s picture

adamps commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.