Problem/Motivation

Icons have the background color #000000. Therefore in some color schemes, especially dark mode, they are not displayed properly.

Steps to reproduce

Use, e.g., dark mode in Gin Admin Theme.

Proposed resolution

Let icons inherit fill color.

Remaining tasks

Review MR.

CommentFileSizeAuthor
#4 3377950-4-after.png85.27 KBshyam_bhatt
#4 3377950-4-before.png84.77 KBshyam_bhatt
#3 after.png55.25 KBsimonbaese
#3 before.png55.28 KBsimonbaese

Issue fork ckeditor_accordion-3377950

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

simonbaese created an issue. See original summary.

simonbaese opened merge request !9

simonbaese’s picture

simonbaese
Location Berlin
commented
Assigned: simonbaese » Unassigned
Status: Active » Needs review
StatusFileSize
new before.png55.28 KB
new after.png55.25 KB

Adjusted the icons.

Before:
Black icon in dark mode

After:
Correct color for icon

shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3377950-4-before.png84.77 KB
new 3377950-4-after.png85.27 KB

@simonbaese I have checked the "MR !9", the accordion module icon on the CKEditor 5, visible in white with the GIN as admin them and visible in black with the GIN light theme.

Please check the images below:

Before MR:
2023-10-03/3377950-4-before.png

After MR:
2023-10-03/3377950-4-after.png

Moving to +RTBC.

j-vee’s picture

j-vee commented
Status: Reviewed & tested by the community » Fixed

Good catch - fixed in 2.1.0, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.