This reference is wrong inside Drupal.Leaflet.prototype.create_json

I don't think calls to this in Drupal.Leaflet.prototype.create_feature are an issue since they are called at the prototype's function level. Furthermore I would probably have seen the error also there if it was necessary to modify create_feature, my patch alone seems to resolve the issue mentioned in the description.

Hello itamair,

I made a wrapper around leafmet.service with the following method:

  /**
   * @param array $geoJsons
   * @param string $mapName
   *   Voir fei_maps_leaflet_map_info().
   * @param string $mapHeight
   *
   * @return array
   *   Render.
   */
  protected function buildGeoJsonMap(array $geoJsons, $mapName = 'carte_pour_geojsons', $mapHeight = '800px') {

    $this->addGeojsonWarnings($geoJsons);

    $map = leaflet_map_get_info($mapName);
    $features = [];
    foreach ($geoJsons as $tid => $geojson) {
      $geoJsonArray = json_decode($geojson, TRUE);
      // Keep the related tid reference for the click event:
      $geoJsonArray['tid'] = $tid;
      $features[] = [
        'type' => 'json',
        'json' => $geoJsonArray,
        // @see https://www.drupal.org/project/leaflet/issues/3186029#comment-13927181
        'events' => [
          'click' => 'Drupal.manageGeojsonClick',
        ],
      ];
    }
    return $this->leaflet->leafletRenderMap($map, $features, $mapHeight);
  }

The $geoJsons array is containing typical geojson strings as such:

"{"type": "Feature", "properties": { "scalerank": 1, "featurecla": "Admin-0 country", "labelrank": 2.0, "sovereignt": "Argentina", "sov_a3": "ARG", "adm0_dif": 0.0, "level": 2.0, "type": "Sovereign country", "admin": "Argentina", "adm0_a3": "ARG", "geou_dif": 0.0, "geounit": "Argentina", "gu_a3": "ARG", "su_dif": 0.0, "subunit": "Argentina", "su_a3": "ARG", "brk_diff": 0.0, "name": "Argentina", "name_long": "Argentina", "brk_a3": "ARG", "brk_name": "Argentina", "brk_group": null, "abbrev": "Arg.", "postal": "AR", "formal_en": "Argentine Republic", "formal_fr": null, "note_adm0": null, "note_brk": null, "name_sort": "Argentina", "name_alt": null, "mapcolor7": 3.0, "mapcolor8": 1.0, "mapcolor9": 3.0, "mapcolor13": 13.0, "pop_est": 40913584.0, "gdp_md_est": 573900.0, "pop_year": -99.0, "lastcensus": 2010.0, "gdp_year": -99.0, "economy": "5. Emerging region: G20", "income_grp": "3. Upper middle income", "wikipedia": -99.0, "fips_10": null, "iso_a2": "AR", "iso_a3": "ARG", "iso_n3": "032", "un_a3": "032", "wb_a2": " [...]

Looks like it was taken straight out of a dataset such as: https://github.com/datasets/geo-boundaries-world-110m/blob/master/countr...

Then the map is displayed in a typical controller through the method above. Not sure if you need more info about the map settings for example ?

Leaflet Map View as in Views module ?

Sorry but no we were not using the Views module, as described in my previous comment I explained "The map is displayed in a typical controller through the method above".

Could you please explain where to go from the above because your d10 update breaks the geojson layers in our case.

Can you kindly please be more specific with ?

Whichever is the way you generate the Drupal Leaflet map you could (and should) use that approach to add/inject GeoJson resources into that …

?

I mean can't you see how much we were apparently relying on this feature ?
It's like if I got punished to open this issue because you wouldn't have seen this in the first place ? Come on' ...

Doesn't it breaks https://www.drupal.org/project/leaflet/issues/3186029 ?

Thanks for listening, because, actually until now I just applied a patch myself to rollback the changes, otherwise it would have needed a huge rewrite.

Still I hope you could give better evidence of it (may be with a more detailed description, with some code Gists i.e.)and thus give a practical contribution and guidance to the Drupal Leaflet module community ...

I already specifically asked you if you needed more informations about my implementation in comment #10, https://www.drupal.org/project/leaflet/issues/3377403#comment-15190179

The thing is there is not a single line of custom JS nor the need to inject a Drupal setting in this case, neither the use of Views module. It's just a controller which returns a standard render array, and it works as is with the leafletRenderMap from the leaflet service, I thought it was clear from my code snippet ... What is missing from my example above ?