Checkout login and register forms are redefined with Commerce for complete control over forms rendering. but, they have missing some details from Drupal Core Login/Register forms.

CommentFileSizeAuthor
#6 3377142-6.patch9.55 KBvipin.j
#3 3377142-3.patch10.5 KBvipin.j
#2 3377142-2.patch2.95 KBvipin.j

Issue fork commerce-3377142

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vipin.j created an issue. See original summary.

vipin.j’s picture

vipin.j commented
Status: Active » Needs review
StatusFileSize
new 3377142-2.patch2.95 KB

Here is the patch to update missing details.

vipin.j’s picture

vipin.j commented
StatusFileSize
new 3377142-3.patch10.5 KB

Fixing failed test cases.

morbus iff’s picture

morbus iff
they/them
commented

@vipin.j, we need to update this patch. Core's username and password no longer have #descriptions (see https://www.drupal.org/node/3377041), so we don't need those in this patch anymore, but the "Log in" and "Create new account and continue" tweaks should stay.

morbus iff’s picture

morbus iff
they/them
commented
Status: Needs review » Needs work
vipin.j’s picture

vipin.j commented
Status: Needs work » Needs review
StatusFileSize
new 3377142-6.patch9.55 KB

Done.

morbus iff’s picture

morbus iff
they/them
commented
Status: Needs review » Reviewed & tested by the community
morbus iff’s picture

morbus iff
they/them
commented
Status: Reviewed & tested by the community » Needs review

@vipin.j, tests are failing.

vipin.j opened merge request !274

morbus iff’s picture

morbus iff
they/them
commented
Status: Needs review » Reviewed & tested by the community

jsacksick made their first commit to this issue’s fork.

  • jsacksick committed d2630476 on 8.x-2.x authored by vipin.j 
    Issue #3377142: user/login and checkout/#/login should look similar
jsacksick’s picture

jsacksick commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

  • jsacksick committed c1ce735a on 3.0.x authored by vipin.j 
    Issue #3377142: user/login and checkout/#/login should look similar

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.