Problem/Motivation

Found Deprecation

 ------ ----------------------------------------------------------- 
  Line  /src/Plugin/search_api/processor/AddHierarchy.php                                           
 ------ ----------------------------------------------------------- 
  122    Call to deprecated function watchdog_exception():          
         in drupal:10.1.0 and is removed from drupal:11.0.0. Use    
           Use \Drupal\Core\Utility\Error::logException() instead.  
  294    Call to deprecated function watchdog_exception():          
         in drupal:10.1.0 and is removed from drupal:11.0.0. Use    
           Use \Drupal\Core\Utility\Error::logException() instead.

Steps to reproduce

Implement the purposed solution https://www.drupal.org/node/2932520

Proposed resolution

Remaining tasks

CommentFileSizeAuthor
#6 3377099-6--watchdog_exception_deprecated.patch8.88 KBdrunken monkey
#6 3377099-6--watchdog_exception_deprecated--interdiff.txt9.9 KBdrunken monkey

Issue fork search_api-3377099

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

keshav.k created an issue. See original summary.

keshav.k opened merge request !87

keshavv’s picture

keshavv commented
Issue summary: View changes
keshavv’s picture

keshavv commented
Status: Active » Needs review

I have created the MR. Please review.
Thank you.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Postponed
Issue tags: +Drupal 10.1 dependency

Thanks for opening this issue!
However, it seems we need to wait until we depend on Drupal 10.1 to be able to fix this.
Furthermore, there are lots of other places in our code that use that function:

$ git grep -l watchdog_exception
search_api.module
search_api.views.inc
src/IndexBatchHelper.php
src/LoggerTrait.php
src/Plugin/search_api/processor/AddHierarchy.php
src/Task/IndexTaskManager.php
src/Utility/PostRequestIndexing.php
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Postponed » Needs review
StatusFileSize
new 3377099-6--watchdog_exception_deprecated--interdiff.txt9.9 KB
new 3377099-6--watchdog_exception_deprecated.patch8.88 KB

Since we now increased the Core version dependency in #3394192: Increase Drupal core version requirement to 10.1, we can finally go ahead with this.
The attached patch should fix this throughout the module. (Testing MRs unfortunately still doesn’t work for this project.)

  • drunken monkey committed 82394da0 on 8.x-1.x 
    Issue #3377099 by drunken monkey, keshavv: Fixed calls to deprecated...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Merged. Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.