Problem/Motivation

php8.2 compatibility issue

Steps to reproduce

Deprecated function: Creation of dynamic property Drupal\panels\Plugin\DisplayVariant\PanelsDisplayVariant::$pattern is deprecated in Drupal\panels\Plugin\DisplayVariant\PanelsDisplayVariant->getPattern() (line 227 of modules/contrib/panels/src/Plugin/DisplayVariant/PanelsDisplayVariant.php).
Drupal\panels\Plugin\DisplayVariant\PanelsDisplayVariant->getPattern() (Line: 123)

CommentFileSizeAuthor
#2 3376992-php8.2-compatibility.patch588 bytesconnbi

Comments

bijiaxing created an issue. See original summary.

connbi’s picture

connbi commented
StatusFileSize
new 3376992-php8.2-compatibility.patch588 bytes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Needs review

This looks good to me, compared with the current automated test results, the above patch actually fixes a fail compared to head 8.1 tests.

Status: Needs review » Needs work

The last submitted patch, 2: 3376992-php8.2-compatibility.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs work » Reviewed & tested by the community

The patch improves test results

RTBC!

Thank you!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 8.x-4.7 » 8.x-4.x-dev
Status: Reviewed & tested by the community » Fixed

Thank you both @joseph.olstad and @bijiaxing

  • joelpittet committed ce7e9195 on 8.x-4.x authored by bijiaxing 
    Issue #3376992 by bijiaxing, joseph.olstad: php8.2 compatibility missing...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

subir_ghosh’s picture

subir_ghosh
Primary language English
Location Delhi/Bangalore/Calcutta
commented

Tha patch works. Thank you.