Problem/Motivation

I'd like my client to be able to upload / update the H5P Libaries without having the very bulky "administer site configuration" permission.

Steps to reproduce

Install the module and try to access /admin/content/h5p with a user that does not have the "administer site configuration" permission.

Proposed resolution

Add a new permission that can be assigned without giving the user access to global site configuration.

Remaining tasks

Define Permission and change route permission checks.

User interface changes

Newly added permission.

API changes

None.

Data model changes

None.

Issue fork h5p-3376847

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fisherman90 created an issue. See original summary.

fisherman90 opened merge request !13

fisherman90’s picture

fisherman90
Primary language German
Location Dortmund
commented
Status: Active » Needs review

msandoval made their first commit to this issue’s fork.

msandoval opened merge request !44

msandoval’s picture

msandoval commented
Version: 2.0.0-alpha3 » 2.0.x-dev

Checked that permissions still work for users with just the 'administer h5p libraries' permissions. Confirmed that there aren't references to 'administer site configuration' in the rest of the h5p module, so just the changes from the patch are necessary for this issue.

illeace’s picture

illeace commented
Version: 2.0.x-dev » 2.0.0-alpha3
Status: Needs review » Reviewed & tested by the community

I checked out this branch and the changes worked for me as well. Setting to RTBC.

sim_1 changed the visibility of the branch 3376847-less-generic-permission-for-admin-views to hidden.

sim_1 changed the visibility of the branch 3376847-less-generic-permission-for-admin-views to active.

sim_1 changed the visibility of the branch 3376847-less-generic-permission-for-admin-views to hidden.

sim_1 changed the visibility of the branch 2.0.x to hidden.

  • sim_1 committed 1c638f0c on 2.0.x authored by msandoval 
    [#3376847] fix: Admin page permissions too generic

By: fisherman90
By:...
sim_1’s picture

sim_1
she/her
commented
Status: Reviewed & tested by the community » Fixed

Great, thank you! Merged and marking as fixed.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.