Problem/Motivation

Scanned the module using phpcs ../vendor/bin/phpcs --standard=drupal modules/contrib/honeypot/ and found that there are many use statements that need to be reordered alphabetically.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
honeypot-phpcs.txt3.81 KBkeshavv

Issue fork honeypot-3376833

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

keshav.k created an issue. See original summary.

keshav.k opened merge request !17

keshavv’s picture

keshavv commented
Status: Active » Needs review

Fixed all issues and created the MR.
Please review.
Thank you.

tr’s picture

tr commented
Status: Needs review » Needs work

The bulk of this patch is alphabetizing the "use" statements. That's not a coding standard used by Drupal, but I'm not opposed to that. If you want to change this issue title and summary and create a new patch that does just that then we can get this committed.

The other changes won't be fixed for reasons I have repeatedly mentioned. Also the test failed, which indicates one of your changes was wrong.

keshavv’s picture

keshavv commented
Title: Drupal coding standard. » Sort 'use' statements alphabetically.
Issue summary: View changes
keshavv’s picture

keshavv commented
Status: Needs work » Needs review

@TR, Thank you.
I have updated the issue summary and MR as well.
Please review.

  • TR committed 00da50ee on 2.1.x authored by keshav.k 
    Issue #3376833: Sort 'use' statements alphabetically
tr’s picture

tr commented
Category: Bug report » Task
Status: Needs review » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.