missing @return in docs for ExternalEntityStorageClientInterface::query()

Thanks for the patch!

I'm not sure each item has to be an array, as one of the callers of this method does this:

    $query_results = $this->getStorageClient()->query($this->parameters, $this->sort, $start, $length);

SNIP 

    foreach ($query_results as $query_result) {

      $id = $field_mapper->extractIdFromRawData((array) $query_result);

Needs work as per my comment.

@roberttabigue thanks for reviewing, but please don't upload screenshots of code! We can see the patch applies - the test is green. And we can see the change the patch makes -- that's what the diff is for.

+++ b/src/StorageClient/ExternalEntityStorageClientInterface.php
@@ -77,6 +77,9 @@ interface ExternalEntityStorageClientInterface extends PluginInspectionInterface
+   *   A single external entity or array of raw data arrays each representing an external entity.

It can't be a single entity, because:

    $query_results = $this->getStorageClient()->query($this->parameters, $this->sort, $start, $length);
    $field_mapper = $this->getExternalEntityType()->getFieldMapper();
    $result = [];
    foreach ($query_results as $query_result) {
      $id = $field_mapper->extractIdFromRawData((array) $query_result);
      if (!empty($id)) {
        $result[$id] = $id;
      }
    }