Warning: Undefined array key "iss_allowed_domains"

Yes I need this also , running PHP 8.1 with the 3x branch.

In my opinion, this is a mistake at the update_Ns level where the existing configuration does not get this key set. For new configuration entities, the key will always be there. The code is supposed to work for all cases, so if no update hook is provided to fix this, I'd rather just resave the existing converted configuration and that will fix the warning.

@bbu23 , sorry but it looks like your account has been hacked, so I marked your comment as spam. I don't usually do this but your comment shows that you most likely didn't look at the code in the merge request and your last comment is totally out of context.

@joseph.olstad I don't appreciate that accusation and your answer. I most definitely checked the MR, locally tested and I am very confident that the change is not necessary. The "iss_allowed_domains" setting is added later to the base configuration and all existing config entities are affected by that until they are saved once. This is because no update_N hooks are covering it. A configuration form like that is not supposed to have an isset scenario because the default values exist in the schema. This change is still unnecessary in my opinion. Plus that MR covers only the form. The rest of the code is supposed to get that as an empty string anyways if nothing special is set.

And marking my comment as spam just because you disagree or don't understand my point is bm and uncalled for.

I agree with her. Not spam, and definitely something that could be fixed with an update hook. It's completely relevant.

Indeed, let's fix this better with a hook_update..

Sorry @bbu23, my mistake, I seriously thought you were some chat GPT bot but I see that you are real.

I've come accross this situation again with the 3.x version of openid_connect in Drupal 10,

MR needs to be changed to use hook_update_N

As suggested by others in this thread, I have created a new issue fork and added a new hook_update_N for adding the missing "iss_allowed_domains".

I closed MR #86 in favor of MR #143. I added an update test to confirm the changes. If someone wants to review and mark this RTBC, I'll get it merged.

I'm marking this needs work to fix the update hook as it conflicts with the update hook introduced in #3375886: Warning: Undefined array key "iss_allowed_domains".

The rebase has been completed. Marking this needs review.

Looks good to me.

Thanks everyone! The merge train has begun.