Problem/Motivation

Discovered #3357969: For web server dependent unattended updates run the entire life cycle in a separate process that will not be affected by hosting time limits and makes this hard to test because when terminal multiple times with delays(because still don't run status checks more than 1x hour) this CronFrequencyValidator will start to error if you delay too long.

but the whole purpose CronFrequencyValidator is to ensure that updates and status checks will be run. but if you select "console" this will not happen via cron anyways so it is not valid check.

If you select "console" to run updates you should be able to run cron 1x day or less if that is all you need otherwise

Steps to reproduce

Exit early in CronFrequencyValidator if "console" method has been chosen to run updates

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tedbow created an issue. See original summary.

tedbow’s picture

Assigned: Unassigned » phenaproxima
Status: Active » Needs review

I think this is simple fix and don't expect other tests break🤞🏻

phenaproxima’s picture

Assigned: phenaproxima » tedbow
Status: Needs review » Needs work

We could be a tad less verbose but the changes here make sense to me.

tedbow’s picture

Assigned: tedbow » phenaproxima
Status: Needs work » Needs review

@phenaproxima applied your suggestions

phenaproxima’s picture

Assigned: phenaproxima » Unassigned
Status: Needs review » Reviewed & tested by the community

  • tedbow committed 27373b7c on 3.0.x
    Issue #3375679: CronFrequencyValidator should not check if updates will...
tedbow’s picture

Status: Reviewed & tested by the community » Fixed

🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.