Problem/Motivation

\Drupal\automatic_updates\Validation\StatusChecker::getLastRunTime is only tested because we test automatic_updates_cron but since it is public method on our service we should test it directly.

Steps to reproduce

Proposed resolution

Test it in \Drupal\Tests\automatic_updates\Kernel\StatusCheck\StatusCheckerTest

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork automatic_updates-3375640

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Title: StatusChecker::getLastRunTime() is only test indirectly » StatusChecker::getLastRunTime() is only tested indirectly

phenaproxima made their first commit to this issue’s fork.

phenaproxima opened merge request !954

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » tedbow
Status: Active » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Needs review » Reviewed & tested by the community

Thanks, good to get this done

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

  • phenaproxima committed b7101e97 on 3.0.x 
    Issue #3375640 by phenaproxima: StatusChecker::getLastRunTime() is only...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.