Problem/Motivation

Currently the fields language, status and created are missing for "manage form display" settings. The first two fields are instead hard-coded in SubscriberForm::form(). This means the GUI admin has no option to configure the display settings, and it means redundant code to maintain.

Proposed resolution

  1. Call setDisplayConfigurable('form')
  2. Remove the hard-coded fields
  3. Fix field access settings so that status cannot be set if there is a corresponding user.
  4. Put a link on the subscriber form to edit the corresponding user.

Remaining tasks

User interface changes

Changes to subscriber form display. The default settings are a fairly close match to the previous hard-coded settings.

API changes

Data model changes

CommentFileSizeAuthor
#8 simplenews.subscriber-form-display.3375320-8.patch1.02 KBadamps
#4 simplenews.subscriber-form-dislpay.3375320-interdiff-2-4.txt2.62 KBadamps
#4 simplenews.subscriber-form-dislpay.3375320-4.patch7.03 KBadamps
#2 simplenews.subscriber-form-dislpay.3375320-2.patch4.9 KBadamps

Comments

AdamPS created an issue. See original summary.

adamps’s picture

adamps commented
Status: Active » Needs review
StatusFileSize
new simplenews.subscriber-form-dislpay.3375320-2.patch4.9 KB

Some of this change was already committed as part of #3332695: Model for confirmations is flawed.

Status: Needs review » Needs work

The last submitted patch, 2: simplenews.subscriber-form-dislpay.3375320-2.patch, failed testing. View results

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new simplenews.subscriber-form-dislpay.3375320-4.patch7.03 KB
new simplenews.subscriber-form-dislpay.3375320-interdiff-2-4.txt2.62 KB
adamps’s picture

adamps commented

  • AdamPS committed 243d023a on 4.x 
    Issue #3375320 by AdamPS: User "manage form display" for subscriber base...
adamps’s picture

adamps commented
Title: User "manage form display" for subscriber base fields » Use "manage form display" for subscriber base fields
Status: Needs review » Fixed
adamps’s picture

adamps commented
Status: Fixed » Needs review
StatusFileSize
new simplenews.subscriber-form-display.3375320-8.patch1.02 KB

Unfortunately setting the langcode entity key has side effects (all existing subscriptions didn't show up because they had the wrong langcode), so undo that part.

  • AdamPS committed 5224128a on 4.x 
    Issue #3375320 by AdamPS: Use "manage form display" for subscriber base...
adamps’s picture

adamps commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.