Grid Widget module defines a field widget that extends Drupal core's field options widget to display Text, Numeric, and Entity Reference fields as selection checkboxes/radio buttons in a grid with CSS styling based on CSS grid systems (Columns, Flexbox, and Grid).

Project link

https://www.drupal.org/project/grid_widget

Comments

LittleCoding created an issue. See original summary.

vinaymahale’s picture

Issue summary: View changes
vinaymahale’s picture

Issue summary: View changes
DSushmita’s picture

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

avpaderno’s picture

Issue summary: View changes
kevin.brocatus’s picture

A quick run of phpcs --standard=Drupal,DrupalPractice seems to be all good!

Looking through the code in detail I do not see any issues either. Only thing I found was an unnecessary blank line in the form() function in the OptionsGridWidget.php;

    elseif ($property_selected === 'flex') {

      $field_widget_complete_form['#attributes']['data-flex-size'] = (int) $this->getSetting('size');
    }

shashank5563’s picture

Status: Needs review » Needs work
avpaderno’s picture

Status: Needs work » Needs review

A single empty line that should be removed is not sufficient to change the status to Needs work. If there is anything else that should be changed, let us report that too.

littlecoding’s picture

The identified grammatical mistake and unneeded whitespace has been fixed. Changes can been found in 1.0.x-dev and will be part of the next minor release. Thank you @vinaymahale and @kevin.brocatus for flagging these.

littlecoding’s picture

Is there any more feedback or would someone else like to review?

vinaymahale’s picture

Priority: Normal » Major
vinaymahale’s picture

Priority: Major » Normal
Status: Needs review » Reviewed & tested by the community

No issues found
Changing to RTBC

avpaderno’s picture

Assigned: Unassigned » avpaderno

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

avpaderno’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.