Problem/Motivation

The code have to follow all the best practices.

Remaining tasks

  • Drupal 10 and PHP 8+ compatibility - test and fix.
  • PHPCS and Drupal code style practices check.
  • Write Unit tests.

Some of those were handled with the help of community.

CommentFileSizeAuthor
#7 After patch 3374762.png18.78 KBriddhi.addweb

Issue fork convert_currencies-3374762

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

danny-dee created an issue. See original summary.

danny-dee’s picture

danny-dee commented
Issue summary: View changes

silvi.addweb made their first commit to this issue’s fork.

silvi.addweb opened merge request !1

silvi.addweb’s picture

silvi.addweb commented
Status: Active » Needs review

Hello,

I created an MR and fixed phpcs problems. Review, please.

nilesh.addweb made their first commit to this issue’s fork.

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new After patch 3374762.png18.78 KB

I have applied the patch and all the phpcs issues are fixed.
Please find the screenshot for the same.

danny-dee’s picture

danny-dee commented

The code was updated for Drupal 11 compatibility and PHPCS issues are fixed now.

danny-dee’s picture

danny-dee commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.