Problem/Motivation

New Revision UI was added in #2350939: Implement a generic revision UI and any revisionable entity can extend it by following this change record. When trying to revert a entity which have multiple translations, one would expect that only that translation is reverted as is the case for node (which currently do not use the New Revision UI - #2453153: Node revisions cannot be reverted per translation) but this reverts all of the translations and a new revision which is copy of one of the old revision of that langauage's translation gets created.

Steps to reproduce

media_revision_ui 3.x version uses New Revision UI to provide this interface for revisionable media.

1. Setup a multilingual Drupal site with atleast 2 languages.
2. Install Core media and contrib media_revision_ui(v3.x) module.
3. Make a media type revisionable.
4. Create several revisions for this media type in each language.
5. Trying reverting a revision in any of the translation.
6. After reverting, a new reverted revision is created for each of the language. Only the reverted language is reverted to correct old revision and other translations point to random old revisions.

Expected: Only the translation which is being reverted should have the new reverted revision and other translation revision should not be impacted.

Comments

sumit_saini created an issue. See original summary.

sumit saini’s picture

sumit saini commented
Parent issue: » #2350939: Implement a generic revision UI
acbramley’s picture

acbramley commented
Related issues: +#3356684: Generic Revision UI's Revision overview page generates wrong operations/view links for a translation
acbramley’s picture

acbramley commented

Added related issue, I wonder if this is just a symptom of that? I.e we're technically rendering revisions from the default translation, not the current translation.

acbramley’s picture

acbramley commented
Status: Active » Postponed (maintainer needs more info)

I cannot reproduce this issue with #2911977: Add Media revision UI and the latest work on 11.x.

I'm willing to bet this was a symptom of #3356684: Generic Revision UI's Revision overview page generates wrong operations/view links for a translation as per #4

Setting to postponed as I need someone more familiar with translations to double check my work but I followed these steps:

Installed demo_umami while on the branch from this MR https://git.drupalcode.org/project/drupal/-/merge_requests/4057/diffs
Edited Media 21 (an Image about Pork ribs) multiple times in both translations
Reverted the Spanish translation
Checked the English translation
Made more edits
Reverted the English translation

Everything looked as it should at all steps.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)
Issue tags: +Bug Smash Initiative

Since there's been no follow up to #5 going to close out, but if still an issue in D11 please re-open maybe updating the summary with steps to reproduce in todays setup.

Thanks all!