Problem/Motivation

In #3123832: [META] Fix @todo items referencing closed issues we've discovered there's a @todo in \Drupal\form_test\Plugin\Block\RedirectFormBlock::getCacheMaxAge.
This @todo is linked to an d.o. issue that is already closed: #2351015: URL generation does not bubble cache contexts.

This is the @todo:

  /**
   * {@inheritdoc}
   *
   * @todo Make cacheable once https://www.drupal.org/node/2351015 lands.
   */
  public function getCacheMaxAge() {
    return 0;
  }

Steps to reproduce

Proposed resolution

Remove the getCacheMaxAge() in this class.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3373826

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Spokje created an issue. See original summary.

spokje’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Simple change that didn't seem to break anything. Will mark for you.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed 764e139 and pushed to 11.x. Thanks!

  • catch committed a01ef884 on 11.x
    Issue #3373826 by Spokje: Make \Drupal\form_test\Plugin\Block\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.