Problem/Motivation

FILE: /var/www/html/vb/d_cont/vcp4dates/src/Plugin/views/cache/DateFilter.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
29 | ERROR | [ ] Parameter $configuration is not described in comment
29 | ERROR | [ ] Parameter $plugin_id is not described in comment
29 | ERROR | [ ] Parameter $plugin_definition is not described in comment
35 | ERROR | [ ] Unknown type hint "TimeInterface" found for $time
68 | ERROR | [ ] The array declaration extends to column 107 (the limit is
| | 80). The array content should be split up over multiple
| | lines
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/vcp4dates/vcp4dates.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name, for
| | example "drupal:"
--------------------------------------------------------------------------------

Time: 103ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig vcp4dates/

Remaining tasks

Patch review

CommentFileSizeAuthor
coding-standard-fixes.patch2.02 KBurvashi_vora

Issue fork vcp4dates-3373781

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

urvashi_vora created an issue. See original summary.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

Hi, whilst I appreciate coding standards patches, my policy is not to give credit to contributors who already have credit for coding standards patches. Coding standards patches are great for folks finding their feet with the mechanics of contribution, but more experienced developers can help in other ways. Please refer to tip 2 on https://www.previousnext.com.au/blog/5-simple-tips-increase-your-drupal-... for more information.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Version: 1.0.0-alpha1 » 1.x-dev
a.aaronjake’s picture

a.aaronjake commented
Status: Needs review » Reviewed & tested by the community

Hi @darvanen,

Applied the patch above and found all issues were fixed. 

contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig vcp4dates/
➜  contrib git:(main) ✗

Thank you.

darvanen opened merge request !3

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented

They really weren't. I've re-done this and taken the opportunity to resolve some issues with the tests.

  • darvanen committed 5e41bf4f on 1.x 
    task: #3373781 Fix the issues reported by phpcs

By: darvanen

darvanen opened merge request !4

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.