Fix the warnings/errors reported by PHP_CodeSniffer

I fixed the remaining phpcs issues.

I tried to rebase the merge request but due to the recent changes this led to git conflicts and I could not safely resolve these.

So I took the low hanging fruit phpcs fixes from your merge requests and committed these.

This means there are 2 phpcs errors left that need to be fixed:

FILE: /var/www/html/web/modules/contrib/country/src/Plugin/Field/FieldFormatter/CountryDefaultFormatter.php
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 27 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/contrib/country/src/Plugin/Field/FieldWidget/CountryAutocompleteWidget.php
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 37 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------

I close the merge request, and set this issue to Needs Work

Fixed issues. Please review.

Hi nitin_lama,

I reviewed MR!10 and applied it against Country 8.x-1.x-dev with Drupal core version 10.1.7 and confirmed it fixes the issues reported by phpcs.

I added screenshots for reference.
Thank you.

public function getList() in CountryFieldManager should not be removed as long as it is used. And you revert some changes made by other issues in the meantime. Is this intended?

As mentioned in #8 : there are 2 phpcs errors that still need fixing.

Can you restrict your changes just to the 2 remaining phpcs errors?

If you think other issues need to be addressed, please create another issue.

If you have other phpcs output, please post it here as well

@batigolix Addressed #8 please review patch.

This is starting to look very good. Just a couple of small remarks;

+  public function __construct(CountryFieldManager $countryFieldManager) {
+    $this->countryFieldManager = $countryFieldManager;
+  }

You will need to call the parent::__construct() here, otherwise the non overridden functions in FormatterBase are missing services. The current implementation breaks the settings of the field.

+  public function __construct(CountryFieldManager $countryFieldManager) {
+    $this->countryFieldManager = $countryFieldManager;
+  }

That means this will also needs more parameters.

+  /**
+   * {@inheritdoc}
+   */

Bonus points for replacing this with the correct parameter definitions.

Please review Patch #22 addressed.

If I go to /admin/structure/types/manage/article/form-display and switch from the Default Widget to the Autocomplete Widget, then I get this error:

TypeError: Drupal\Core\Field\WidgetBase::__construct(): Argument #5 ($third_party_settings) must be of type array, null given, called in /var/www/html/web/modules/contrib/country/src/Plugin/Field/FieldWidget/CountryAutocompleteWidget.php on line 63 in Drupal\Core\Field\WidgetBase->__construct() (line 50 of /var/www/html/web/core/lib/Drupal/Core/Field/WidgetBase.php).

Fixed Error mentioned in #24. please review updated patch, Thanks

I tested this and it works now. I committed this.

Thanks everybody for their help