FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/webform_product.routing.yml
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------
6 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
13 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
20 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
--------------------------------------------------------------------------------------------------------------------
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/src/WebFormProductFormHelper.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $element_info.
-------------------------------------------------------------------------------------------------------------------------
Time: 532ms; Memory: 16MB| Comment | File | Size | Author |
|---|---|---|---|
| #6 | fixes-error-phpcs-3372977-6.patch | 8.33 KB | nagy.balint |
| #4 | Screenshot 2024-02-27 at 12.41.03 PM.png | 165.93 KB | ashutosh ahirwal |
| #3 | fixes-error-phpcs-3372977-2.patch | 9.26 KB | roshni27 |
Comments
Comment #2
roshni27 commentedComment #3
roshni27 commentedI have fixed all errors ,Please review patch.
Comment #4
ashutosh ahirwal commentedHi Provided patch get applied cleanly but still found some error.
Used command with arguments:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/webform_product
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/webform_product.routing.yml
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------
6 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
13 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
20 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
--------------------------------------------------------------------------------------------------------------------
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/src/WebFormProductFormHelper.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $element_info.
-------------------------------------------------------------------------------------------------------------------------
Time: 532ms; Memory: 16MB
Comment #5
zkhan.aamir commentedIssue summary updated.
Comment #6
nagy.balint commentedUpdated patch
Comment #7
nagy.balint commentedComment #9
nagy.balint commentedComment #11
nagy.balint commentedNow it only does not like the api.php, but it should not analyse that anyways.