Problem/Motivation

FILE: ...iews_filter_block/src/Plugin/Block/ConfigurableViewsExposedFilterBlock.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
125 | ERROR | [x] Return comment indentation must be 3 spaces, found 2 spaces
318 | ERROR | [ ] Type hint "array" missing for $element
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 90ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig configurable_views_filter_block/

Remaining tasks

Patch review

CommentFileSizeAuthor
#6 after_applying_MR.png65.73 KBparaderojether
coding-standard-fixes.patch1.06 KBurvashi_vora

Issue fork configurable_views_filter_block-3372769

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

urvashi_vora created an issue. See original summary.

paraderojether’s picture

paraderojether commented
Status: Needs review » Needs work

Hi

I reviewed patch coding-standard-fixes.patch and still getting the error shown below: 

FILE: ...t/modules/contrib/configurable_views_filter_block/src/Plugin/Block/ConfigurableViewsExposedFilterBlock.php
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 164 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------

Time: 300ms; Memory: 10MB

Please check.
Thank you.

urvashi_vora’s picture

urvashi_vora commented
Status: Needs work » Needs review

I have resolved that error. Please review the MR.

urvashi_vora opened merge request !5

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 1.0.0-alpha1 » 1.0.x-dev
paraderojether’s picture

paraderojether commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after_applying_MR.png65.73 KB

I reviewed MR!5, applied against Configurable Views Filter Block 1.0.x-dev, and confirmed it fixes the issues reported by phpcs.

I added screenshot for reference.
Thank you.

manuel.adan made their first commit to this issue’s fork.

manuel.adan’s picture

manuel.adan
Location 🌌
commented
Status: Reviewed & tested by the community » Fixed

Reviewed & committed, automatic tests are now green. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.