Problem/Motivation

Sort of a bug report/ sort of a feature request. Module homepage says it can do these two things:

  1. generate email notifications when content was added, updated, or deleted; and
  2. generate email notices about content that had gone 6 months without being reviewed

If you eg, don't use (1) every insert/update/delete of a node triggers a logger message like "Simple content notifications is installed but not configured.". Yet it can be configured eg for option (2) only.

Steps to reproduce

Configure only review notifications
Save any node
Watch logs get filled

Proposed resolution

Add an option to disable the logger

Remaining tasks

MR/Patch on the way

User interface changes

Adds a settings option to the admin config form, provides an update hook to maintain status quo (ie, enabled logging)

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 3372256-and-3372260-simple_content_notifications-combined.patch11.79 KBscott_euser

Issue fork simple_content_notifications-3372256

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

scott_euser opened merge request !3

scott_euser’s picture

scott_euser commented
Status: Active » Needs review
scott_euser’s picture

scott_euser commented
Assigned: scott_euser » Unassigned
scott_euser’s picture

scott_euser commented
StatusFileSize
new 3372256-and-3372260-simple_content_notifications-combined.patch11.79 KB

Also combined patch attached for #3372256 + #3372260 since these have a merge conflict in the update hook (since both require a new update hoo)

aaronpinero’s picture

aaronpinero commented
Status: Needs review » Needs work

@scott_euser I am thinking that I might, while working on the other issue, split this into two configuration options so logging for each type of notification (content updates vs content review) can be enabled/disabled separately. Right now, the option makes it seem like this option is just for logging with content update notifications.

scott_euser’s picture

scott_euser commented
Assigned: Unassigned » scott_euser

Makes sense to me given there are two config pages, will update the MR with this shortly.

scott_euser’s picture

scott_euser commented
Assigned: scott_euser » Unassigned
Status: Needs work » Needs review

Updated the MR splitting into two configurations. Thanks!

scott_euser’s picture

scott_euser commented
Status: Needs review » Fixed

Thanks! Changed to fixed since its committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.