FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\freelinking\src\FreelinkingManager.php
----------------------------------------------------------------------------------------------------------------------------------------------
122 | WARNING | Unused variable $key.
----------------------------------------------------------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\freelinking\src\Plugin\Filter\Freelinking.php
-------------------------------------------------------------------------------------------------
177 | WARNING | Unused variable $plugin_name.
-------------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\freelinking\tests\src\Functional\FreelinkingFilterTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
35 | WARNING | Unused variable $root_path.
-----------------------------------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#2 3371034-2.patch1.91 KBarti_parmar

Comments

arti_parmar created an issue. See original summary.

arti_parmar’s picture

arti_parmar commented
Assigned: arti_parmar » Unassigned
Priority: Normal » Minor
Status: Active » Needs review
StatusFileSize
new 3371034-2.patch1.91 KB

Kindly review patch.

indrapatil’s picture

indrapatil commented
Status: Needs review » Reviewed & tested by the community

reviewed the patch it's working So moving to RTCB

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/src/FreelinkingManager.php
@@ -119,7 +119,7 @@ class FreelinkingManager extends DefaultPluginManager implements FreelinkingMana
-    foreach ($items as $key => $item) {

+++ b/src/Plugin/Filter/Freelinking.php
@@ -174,7 +174,7 @@ EOF;
-    foreach ($allowed_plugins as $plugin_name => $plugin_info) {

I am always hesitant to use foreach without a key or index defined due to Drupalgeddon so I would prefer to keep these variables.

I'm now using GitLab CI so patch work flow is deprecated. Setting to needs work for that and comment above.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Title: Unused variable $key. » Remove some unused variables
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs work » Closed (outdated)