Problem/Motivation

Deprecated function: Creation of dynamic property Drupal\email_tfa\EventSubscriber\EmailTfaSubscriber::$request is deprecated in Drupal\email_tfa\EventSubscriber\EmailTfaSubscriber->__construct() (line 114 of modules/contrib/email_tfa/src/EventSubscriber/EmailTfaSubscriber.php).

Steps to reproduce

Use on php 8.2

Proposed resolution

Add moduleHandler property

Remaining tasks

Nothing

User interface changes

Nothing

API changes

Nothing

Data model changes

Nothing

CommentFileSizeAuthor
#10 oie_KTsSO4xm58oO.png352.63 KBchancenyasulu
#7 email_tfa-dynamic-property-deprecated-3370549-6.patch5.56 KBara martirosyan
#6 email_tfa-dynamic-property-deprecated-3370549-6.patch5.27 KBara martirosyan
#2 email_tfa-dynamic-property-deprecated-3370549-2.patch4.05 KBchesn0k

Issue fork email_tfa-3370549

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chesn0k created an issue. See original summary.

chesn0k’s picture

chesn0k
Location Ukraine, Odessa
commented
StatusFileSize
new email_tfa-dynamic-property-deprecated-3370549-2.patch4.05 KB

Removed all use of dynamic properties in this patch.

chesn0k’s picture

chesn0k
Location Ukraine, Odessa
commented
Status: Active » Needs review

maximkashuba made their first commit to this issue’s fork.

maximkashuba opened merge request !10

ara martirosyan’s picture

ara martirosyan commented
StatusFileSize
new email_tfa-dynamic-property-deprecated-3370549-6.patch5.27 KB

I tried to combine the patch #2 and MR #5 into a single patch

ara martirosyan’s picture

ara martirosyan commented
StatusFileSize
new email_tfa-dynamic-property-deprecated-3370549-6.patch5.56 KB

abdulaziz zaid changed the visibility of the branch 3370549-creation-of-dynamic to hidden.

abdulaziz zaid changed the visibility of the branch 3370549-creation-of-dynamic to active.

chancenyasulu’s picture

chancenyasulu commented
Status: Needs review » Needs work
StatusFileSize
new oie_KTsSO4xm58oO.png352.63 KB

I applied the patch #7 but am still getting this issues.

chancenyasulu’s picture

chancenyasulu commented

private ?\Symfony\Component\HttpFoundation\Request $request;

/**
* @var \Drupal\Core\Extension\ModuleHandlerInterface
*/
private ModuleHandlerInterface $moduleHandler;

Module needs these property in web/modules/contrib/email_tfa/src/EventSubscriber/EmailTfaSubscriber.php

abdulaziz zaid’s picture

abdulaziz zaid
Primary language Arabic
Location Riyadh 🇸🇦
commented
Status: Needs work » Fixed

The mirage is working fine.
Merged ! 10 🎉

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.