Problem/Motivation

If there is an issue with communicating with the API defined in an external entity type or an external entity has been deleted the site crashes with Guzzle errors and stack trace on screen.

Steps to reproduce

Change the API URL to a non-existent URL. Go to the page listing that external content.

Proposed resolution

Add error handling to the Storage Clients

Remaining tasks

Verify the patch supplied

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
add_exception_management.patch11.4 KBrory downes

Issue fork external_entities-3368304

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Rory Downes created an issue. See original summary.

pefferen made their first commit to this issue’s fork.

shiv_yadav’s picture

shiv_yadav
Primary language English
commented
Assigned: Unassigned » shiv_yadav
shiv_yadav’s picture

shiv_yadav
Primary language English
commented
Assigned: shiv_yadav » Unassigned
pefferen’s picture

pefferen commented
Assigned: Unassigned » pefferen
pefferen’s picture

pefferen commented

Added the code from patch, removed the hardcoded check to disable certificate check for local url's, please create an other issue for this unrelated change. ALtered error handling a bit so that the user get a message there are no external entities found. Developers can check the log for the exceptions.

pefferen’s picture

pefferen commented
Status: Active » Reviewed & tested by the community

pefferen opened merge request !28

  • pefferen committed bb4f8890 on 8.x-2.x 
    Issue #3368304 by pefferen, Rory Downes, shiv_yadav: Better error...
pefferen’s picture

pefferen commented
Status: Reviewed & tested by the community » Fixed

committed to dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.